From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1DF5845C304
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 10 Dec 2020 17:44:46 +0300 (MSK)
Date: Thu, 10 Dec 2020 14:44:45 +0000
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20201210144445.222emia5y5p4b5sl@tarantool.org>
References: <58584e4677c66eb40e7ea504382df39be2d5ffef.1607442267.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <58584e4677c66eb40e7ea504382df39be2d5ffef.1607442267.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] test: move error messages into
	logs
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 08 Dec 18:49, Alexander V. Tikhonov wrote:
> Cc: tarantool-patches@dev.tarantool.org
> 
> Found that some tests on fail use box.info* calls to print information,
> like:
> 
>   [024] --- replication/wal_rw_stress.result	Mon Nov 30 10:02:43 2020
>   [024] +++ var/rejects/replication/wal_rw_stress.reject	Sun Dec  6 16:06:46 2020
>   [024] @@ -77,7 +77,45 @@
>   [024]              r.downstream.status ~= 'stopped')    \
>   [024]  end) or box.info
>   [024]  ---
>   [024] -- true
>   [024] +- version: 2.7.0-109-g0b3ad5d8a0
>   [024] +  id: 2
>   [024] +  ro: false
>   [024] +  uuid: e0b8863f-7b50-4eb5-947f-77f92c491827
> 
> It denies test-run from rerunng these tests using checksums, because
> of changing output on each fail, like 'version:' either 'uuid:' fields
> values above. To avoid of it, these calls outputs should be redirected
> to log files using log.error(). Also the same fix made for tests with
> fio.listdir() and fio.stat() on errors.
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/tests-output-to-logs

I've checked your patch into 1.10, 2.5, 2.6 and master.

--
Regards, Kirill Yukhin