From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] Support to run tests with Python 3
Date: Tue, 8 Dec 2020 21:04:26 +0300 [thread overview]
Message-ID: <20201208180426.ul5c2sms35ur4tyl@tkn_work_nb> (raw)
In-Reply-To: <4e30fd34-ece6-eb7b-720f-e019b2511fb2@tarantool.org>
If you want my opinion, I think that the technical changes for support
Python 3 are enough. I don't mind style fixes, though.
> > > - print len(tuple[0]) == size and 'ok' or 'fail',
> > > - print
> > > - print
> > > + print(len(tuple[0]) == size and 'ok' or 'fail', end="")
> > > + print()
> > > + print()
> >
> > 6) What for this `print()` needed? (and in the same changes below).
>
> I don't know why you asked me because I'm not an author of these changes.
>
> But I'll try to answer. <...>
I see, you answered the question, but I would highlight this part of the
discussion.
When you touch some code, you becomes its owner. Any questions like 'how
it supposed to work / how it works' are applicable.
If a developer would legally respond 'it is not my deal' on questions
regarding changed code, we would accumulate tech debts even faster than
now.
Of course, there is a line, where it starts to contradict with a common
sense, but in general a knowledge about the changed code is required to
actually change it.
I find this approach nice. It pushes me to know more and be more
confident about my patches.
prev parent reply other threads:[~2020-12-08 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 9:44 sergeyb
2020-12-01 17:03 ` Leonid Vasiliev
2020-12-06 17:43 ` Sergey Bronnikov
2020-12-08 18:04 ` Alexander Turenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208180426.ul5c2sms35ur4tyl@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] Support to run tests with Python 3' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox