Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin <imun@tarantool.org>
To: sergeyb@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/4] test: add corpus to be used with fuzzers
Date: Mon, 7 Dec 2020 20:34:29 +0300	[thread overview]
Message-ID: <20201207173429.GF5396@tarantool.org> (raw)
In-Reply-To: <38dc0666866f758690683c6e91a2ac2ed2f3306d.1606766417.git.sergeyb@tarantool.org>

Sergey,

Thanks for the patch! Please consider my comments below.

On 30.11.20, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Fuzzing tools uses evolutionary algorithms. Supplying seed corpus consisting
> of good sample inputs is one of the best ways to improve fuzz target’s
> coverage. Patch adds a corpuses that can be used with existed fuzzers.
> The name of each file in the corpus is the sha1 checksum of its contents.

Minor: The body of the commit message should be wrapped up to 72
characters (except the links I believe) according to our guidelines[1].

> 
> Corpus with http headers was added from [1] and [2].
> 
> 1. https://google.github.io/oss-fuzz/getting-started/new-project-guide/#seed-corpus
> 2. https://en.wikipedia.org/wiki/List_of_HTTP_header_fields
> 3. https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers
> 
> The libFuzzer allow to minimize corpus with help of `-merge` flag:
> when 1 is passed, any corpus inputs from the 2nd, 3rd etc. corpus directories
> that trigger new code coverage will be merged into the first corpus directory,
> when 0 is passed an existed corpus will be minimized.

Ditto.

> 
> All provided corpuses in a patch were minimized.
> 
> Part of #1809

I have no idea, how to review this patch further. It looks OK except the
testing fails the way I wrote in the previous reply. So, I stop here.

> ---

<snipped>

> -- 
> 2.25.1
> 

[1]: https://www.tarantool.io/en/doc/latest/dev_guide/developer_guidelines/

-- 
Best regards,
IM

  reply	other threads:[~2020-12-07 17:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 20:24 [Tarantool-patches] [PATCH 0/4] Add fuzzing testing sergeyb
2020-11-30 20:24 ` [Tarantool-patches] [PATCH 1/4] test: add infrastructure for fuzzing testing and fuzzers sergeyb
2020-12-07 17:24   ` Igor Munkin
2020-12-07 19:54     ` Igor Munkin
2020-12-13 18:56     ` Sergey Bronnikov
2020-12-20 13:31       ` Igor Munkin
2020-12-24 10:18         ` Sergey Bronnikov
2020-12-24 13:22           ` Igor Munkin
2020-12-24 17:25             ` Sergey Bronnikov
2020-12-24 17:50               ` Igor Munkin
2020-12-25  7:07                 ` Sergey Bronnikov
2020-12-25  9:02                   ` Igor Munkin
2020-12-25 10:33                     ` Sergey Bronnikov
2020-11-30 20:24 ` [Tarantool-patches] [PATCH 2/4] test: add corpus to be used with fuzzers sergeyb
2020-12-07 17:34   ` Igor Munkin [this message]
2020-12-13 18:56     ` Sergey Bronnikov
2020-11-30 20:24 ` [Tarantool-patches] [PATCH 3/4] travis: build tarantool with ENABLE_FUZZER sergeyb
2020-12-07 17:38   ` Igor Munkin
2020-11-30 20:24 ` [Tarantool-patches] [PATCH 4/4] test: integrate with OSS Fuzz sergeyb
2020-12-07 17:42   ` Igor Munkin
2020-12-01 10:54 ` [Tarantool-patches] [PATCH 0/4] Add fuzzing testing Serge Petrenko
2020-12-01 14:41   ` Sergey Bronnikov
2020-12-01 14:45     ` Serge Petrenko
2020-12-07 17:49 ` Igor Munkin
2020-12-25 13:08 ` Igor Munkin
2020-12-25 14:52 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201207173429.GF5396@tarantool.org \
    --to=imun@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 2/4] test: add corpus to be used with fuzzers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox