From: Igor Munkin <imun@tarantool.org> To: Sergey Bronnikov <sergeyb@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 1/4] test: add infrastructure for fuzzing testing and fuzzers Date: Fri, 25 Dec 2020 12:02:38 +0300 [thread overview] Message-ID: <20201225090238.GD5396@tarantool.org> (raw) In-Reply-To: <a5704ae3-4087-1660-50d6-5b9f5b842e51@tarantool.org> Sergey, On 25.12.20, Sergey Bronnikov wrote: > > On 24.12.2020 20:50, Igor Munkin wrote: > > Sergey, > > > > On 24.12.20, Sergey Bronnikov wrote: > >> Igor, > >> > > <snipped> > > > >>>>>>> 2. Do you need to specify <address> flag once more, when ASAN is > >>>>>>> enabled? If not the hunk above looks excess, doesn't it? > >>>>>> Agree, it was a bad idea to manage UBSan and ASAN flags in yet another > >>>>>> place. > >>> I guess this should be fixed in scope of the first patch, but I see you > >>> squashed it to the last one. Why? > >> It seems because I was triggered by OSS_FUZZ in hunk and squashed it to > >> a commit > >> > >> that introduce an OSS_FUZZ support. Fixed it and also moved > >> add_compile_options() to the first commit too > >> > >> (otherwise project source code is not instrumented with > >> -fsanitize=fuzzer-no-link). > > OK, but I believe we agreed the <address> options should be removed to > > avoid managing ASAN flags here, didn't we? > > Removed asan option and double space in commit message. See no changes on the branch. > <snipped> -- Best regards, IM
next prev parent reply other threads:[~2020-12-25 9:02 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-30 20:24 [Tarantool-patches] [PATCH 0/4] Add fuzzing testing sergeyb 2020-11-30 20:24 ` [Tarantool-patches] [PATCH 1/4] test: add infrastructure for fuzzing testing and fuzzers sergeyb 2020-12-07 17:24 ` Igor Munkin 2020-12-07 19:54 ` Igor Munkin 2020-12-13 18:56 ` Sergey Bronnikov 2020-12-20 13:31 ` Igor Munkin 2020-12-24 10:18 ` Sergey Bronnikov 2020-12-24 13:22 ` Igor Munkin 2020-12-24 17:25 ` Sergey Bronnikov 2020-12-24 17:50 ` Igor Munkin 2020-12-25 7:07 ` Sergey Bronnikov 2020-12-25 9:02 ` Igor Munkin [this message] 2020-12-25 10:33 ` Sergey Bronnikov 2020-11-30 20:24 ` [Tarantool-patches] [PATCH 2/4] test: add corpus to be used with fuzzers sergeyb 2020-12-07 17:34 ` Igor Munkin 2020-12-13 18:56 ` Sergey Bronnikov 2020-11-30 20:24 ` [Tarantool-patches] [PATCH 3/4] travis: build tarantool with ENABLE_FUZZER sergeyb 2020-12-07 17:38 ` Igor Munkin 2020-11-30 20:24 ` [Tarantool-patches] [PATCH 4/4] test: integrate with OSS Fuzz sergeyb 2020-12-07 17:42 ` Igor Munkin 2020-12-01 10:54 ` [Tarantool-patches] [PATCH 0/4] Add fuzzing testing Serge Petrenko 2020-12-01 14:41 ` Sergey Bronnikov 2020-12-01 14:45 ` Serge Petrenko 2020-12-07 17:49 ` Igor Munkin 2020-12-25 13:08 ` Igor Munkin 2020-12-25 14:52 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201225090238.GD5396@tarantool.org \ --to=imun@tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 1/4] test: add infrastructure for fuzzing testing and fuzzers' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox