From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: Mons Anderson <v.perepelitsa@corp.mail.ru>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 1/4] backtrace: allow to specify destination buffer
Date: Sat, 5 Dec 2020 21:52:28 +0300 [thread overview]
Message-ID: <20201205185228.GB2303@grain> (raw)
In-Reply-To: <6ba34f0c-8ce5-75ae-2dd7-19e22432e744@tarantool.org>
On Sat, Dec 05, 2020 at 07:30:28PM +0100, Vladislav Shpilevoy wrote:
> Thanks for the patch!
> > char *
> > -backtrace(void)
> > +backtrace(char *start, char *end)
>
> Why so strange choice of arguments? We almost always use char* + size_t,
> except for a few cases such as code working with tuples, where we 'save'
> time on not calculating 'end' in each next stack frame. Lets be consistent
> and use char* + size_t, not to raise unnecessary questions for such simple
> code.
Since start/end were calculated inside I juts moved them to arguments.
No problem, will use size instead.
next prev parent reply other threads:[~2020-12-05 18:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 15:29 [Tarantool-patches] [PATCH v3 0/4] crash dump: implement sending feedback Cyrill Gorcunov
2020-12-04 15:30 ` [Tarantool-patches] [PATCH v3 1/4] backtrace: allow to specify destination buffer Cyrill Gorcunov
2020-12-05 18:30 ` Vladislav Shpilevoy
2020-12-05 18:52 ` Cyrill Gorcunov [this message]
2020-12-04 15:30 ` [Tarantool-patches] [PATCH v3 2/4] errstat: add crash report base code Cyrill Gorcunov
2020-12-05 18:33 ` Vladislav Shpilevoy
2020-12-05 19:58 ` Cyrill Gorcunov
2020-12-06 15:50 ` Vladislav Shpilevoy
2020-12-04 15:30 ` [Tarantool-patches] [PATCH v3 3/4] crash: use errstat code in fatal signals Cyrill Gorcunov
2020-12-05 18:33 ` Vladislav Shpilevoy
2020-12-05 20:04 ` Cyrill Gorcunov
2020-12-04 15:30 ` [Tarantool-patches] [PATCH v3 4/4] cfg: configure crash report sending Cyrill Gorcunov
2020-12-05 18:34 ` Vladislav Shpilevoy
2020-12-05 18:30 ` [Tarantool-patches] [PATCH v3 0/4] crash dump: implement sending feedback Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201205185228.GB2303@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.perepelitsa@corp.mail.ru \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 1/4] backtrace: allow to specify destination buffer' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox