From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] console: drop unused serpent module
Date: Tue, 1 Dec 2020 15:20:33 +0300 [thread overview]
Message-ID: <20201201122033.cqq7pqhpsbrcnt5w@tkn_work_nb> (raw)
In-Reply-To: <20201113145648.268768-1-gorcunov@gmail.com>
Thanks!
Pushed to master.
WBR, Alexander Turenko.
On Fri, Nov 13, 2020 at 05:56:48PM +0300, Cyrill Gorcunov wrote:
> Since the commit ae7e210 we use internal serializer
> thus we no longer need serpent code.
>
> The patch removes the references from the source code
> and .gitmodules file, still one might need to run
>
> | git submodule deinit -f third_party/serpent
>
> manually to clean up the working tree depending
> on local git version.
>
> Closes #5517
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> issue https://github.com/tarantool/tarantool/issues/5517
> branch gorcunov/gh-5517-drop-serpent
>
> Sasha, please take a very close look. While the commit works
> just fine locally we need to double check if submodule removed
> without any clash.
I removed the directory after the commit and everything looks fine.
The relevant recond in .git/config still exists, but can be deleted
manually.
next prev parent reply other threads:[~2020-12-01 12:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 14:56 Cyrill Gorcunov
2020-11-19 11:55 ` Sergey Bronnikov
2020-11-19 12:05 ` Cyrill Gorcunov
2020-11-19 20:52 ` Cyrill Gorcunov
2020-11-25 9:27 ` Sergey Bronnikov
2020-12-01 9:29 ` Alexander V. Tikhonov
2020-12-01 12:20 ` Alexander Turenko [this message]
2020-12-01 12:22 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201122033.cqq7pqhpsbrcnt5w@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] console: drop unused serpent module' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox