From: Kirill Yukhin <kyukhin@tarantool.org>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] Improve json error message.
Date: Thu, 26 Nov 2020 09:46:18 +0000 [thread overview]
Message-ID: <20201126094618.6xjs54ca4lsosodu@tarantool.org> (raw)
In-Reply-To: <20201008215956.93983-1-roman.habibov@tarantool.org>
Hello,
On 09 Oct 00:59, Roman Khabibov wrote:
> I already have LGTM from Vlad.
>
> Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-4339-json-err
> Issue: https://github.com/tarantool/tarantool/issues/4339
>
> Roman Khabibov (2):
> json: make error messages more readable
> json: print context in error mesages
>
> test/app-tap/json.test.lua | 50 +++++++++++++++-
> third_party/lua-cjson/lua_cjson.c | 97 +++++++++++++++++++++++--------
> 2 files changed, 122 insertions(+), 25 deletions(-)
I've checked your patchset into 2.5, 2.6 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-11-26 9:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 21:59 Roman Khabibov
2020-10-08 21:59 ` [Tarantool-patches] [PATCH 1/2] json: make error messages more readable Roman Khabibov
2020-10-12 8:52 ` Leonid Vasiliev
2020-10-08 21:59 ` [Tarantool-patches] [PATCH 2/2] json: print context in error mesages Roman Khabibov
2020-10-12 9:20 ` Leonid Vasiliev
2020-11-03 9:53 ` roman
2020-11-09 21:21 ` Leonid Vasiliev
2020-10-12 8:51 ` [Tarantool-patches] [PATCH 0/2] Improve json error message Leonid Vasiliev
2020-11-03 10:01 ` roman
2020-11-09 21:22 ` Leonid Vasiliev
2020-11-05 15:44 ` roman
2020-11-12 14:03 ` Alexander V. Tikhonov
2020-11-26 9:46 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126094618.6xjs54ca4lsosodu@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] Improve json error message.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox