From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 05499469710
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 26 Nov 2020 12:46:18 +0300 (MSK)
Date: Thu, 26 Nov 2020 09:46:18 +0000
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20201126094618.6xjs54ca4lsosodu@tarantool.org>
References: <20201008215956.93983-1-roman.habibov@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201008215956.93983-1-roman.habibov@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/2] Improve json error message.
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 09 Oct 00:59, Roman Khabibov wrote:
> I already have LGTM from Vlad.
> 
> Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-4339-json-err
> Issue: https://github.com/tarantool/tarantool/issues/4339
> 
> Roman Khabibov (2):
>   json: make error messages more readable
>   json: print context in error mesages
> 
>  test/app-tap/json.test.lua        | 50 +++++++++++++++-
>  third_party/lua-cjson/lua_cjson.c | 97 +++++++++++++++++++++++--------
>  2 files changed, 122 insertions(+), 25 deletions(-)

I've checked your patchset into 2.5, 2.6 and master.

--
Regards, Kirill Yukhin