Re: [Tarantool-patches] [PATCH] lua/merger: fix NULL dereferences on error paths

[Alexander Turenko <alexander.turenko@tarantool.org>]

Thanks!

Pushed to master, 2.6, 2.5.

Added changelog entries:

 | * Fixed NULL dereference on error paths in merger, usually on a
 |   'wrong' key_def (gh-5450).

WBR, Alexander Turenko.

On Wed, Nov 18, 2020 at 03:27:49PM +0300, Alexander V. Tikhonov wrote:
> Hi Alexander, thanks for the patch, as I see no new degradations found in
> gitlab-ci testing commit criteria pipeline [1], patch LGTM.
> 
> [1] - https://gitlab.com/tarantool/tarantool/-/pipelines/217180398
> 
> On Tue, Nov 17, 2020 at 03:25:48PM +0300, Alexander Turenko wrote:
> > Alexander,
> > 
> > I need your approve before I'll push the patch.
> > 
> > The branch is Totktonada/gh-5450-merger-segfault-on-wrong-key-def. I
> > rebased it upward the latest master and force-pushed today, because
> > gh-5473 was resolved.
> > 
> > CentOS 7 jobs ('centos_7', 'default_gcc_centos_7') failed due to a
> > problem with vault repository. Fixed in [1] and restarted. They passed
> > after it.
> > 
> > 'debug' job failed on engine/ddl.test.lua. Looks similar to [2].
> > 
> > 'freebsd_12_release' job failed on replication/election_qsync.test.lua.
> > Looks similar to [3].
> > 
> > Mac OS 10.15 jobs ('osx_15_release', 'osx_15_release_lto',
> > 'static_build_cmake_osx_15') are still pending.
> > 
> > [1]: https://github.com/packpack/packpack-docker-images/pull/62
> > [2]: https://github.com/tarantool/tarantool/issues/4353
> > [3]: https://github.com/tarantool/tarantool/issues/5430
> > 
> > WBR, Alexander Turenko.