From: Nikita Pettik <korablev@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] Support column addition with <ALTER TABLE>
Date: Wed, 18 Nov 2020 23:07:24 +0000 [thread overview]
Message-ID: <20201118230724.GB23479@tarantool.org> (raw)
In-Reply-To: <20201118172358.GA53565@hpalx>
On 18 Nov 20:23, Alexander V. Tikhonov wrote:
> Hi Roman, thanks for the patchset, as I see no new degradations found
> in gitlab-ci testing commit criteria pipeline [1]. Test jobs based on
> opensuse failed because of external issues and already checked at [2],
> patch LGTM.
Pushed to master, changelog for 2.7 release is added, branch is dropped.
GJ
> [1] - https://gitlab.com/tarantool/tarantool/-/pipelines/218019328
> [2] - https://gitlab.com/tarantool/tarantool/-/pipelines/217893488
>
> On Fri, Apr 03, 2020 at 06:27:50PM +0300, Roman Khabibov wrote:
> > According to the SQL standard, column definition in a
> > <CREATE TABLE> and a <ALTER TABLE ADD COLUMN> is the same. So, I
> > decided to support Tarantool features like AUTOINCREMENT in the
> > alter column description.
> >
> > Roman Khabibov (2):
> > sql: rename TK_COLUMN to TK_COLUMN_NAME
> > sql: support column addition
> >
> > extra/addopcodes.sh | 2 +-
> > extra/mkkeywordhash.c | 5 +-
> > src/box/errcode.h | 2 +
> > src/box/schema_def.h | 1 +
> > src/box/sql/alter.c | 1 +
> > src/box/sql/build.c | 596 +++++++++++++++++++++++------------
> > src/box/sql/expr.c | 42 +--
> > src/box/sql/fk_constraint.c | 2 +-
> > src/box/sql/parse.y | 45 ++-
> > src/box/sql/parse_def.h | 62 ++--
> > src/box/sql/prepare.c | 8 +-
> > src/box/sql/resolve.c | 10 +-
> > src/box/sql/select.c | 10 +-
> > src/box/sql/sqlInt.h | 58 +++-
> > src/box/sql/treeview.c | 2 +-
> > src/box/sql/where.c | 18 +-
> > src/box/sql/whereexpr.c | 12 +-
> > test/box/error.result | 2 +
> > test/sql/add-column.result | 231 ++++++++++++++
> > test/sql/add-column.test.lua | 87 +++++
> > 20 files changed, 892 insertions(+), 304 deletions(-)
> > create mode 100644 test/sql/add-column.result
> > create mode 100644 test/sql/add-column.test.lua
> >
> > --
> > 2.21.0 (Apple Git-122)
> >
prev parent reply other threads:[~2020-11-18 23:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 15:27 Roman Khabibov
2020-04-03 15:27 ` [Tarantool-patches] [PATCH v2 1/2] sql: rename TK_COLUMN to TK_COLUMN_NAME Roman Khabibov
2020-04-24 22:55 ` Vladislav Shpilevoy
2020-08-11 0:34 ` Roman Khabibov
2020-04-03 15:27 ` [Tarantool-patches] [PATCH v2 2/2] sql: support column addition Roman Khabibov
2020-04-24 22:56 ` Vladislav Shpilevoy
2020-07-06 13:37 ` Roman Khabibov
2020-07-12 16:45 ` Vladislav Shpilevoy
2020-08-11 0:34 ` Roman Khabibov
2020-08-19 22:20 ` Vladislav Shpilevoy
2020-09-11 21:51 ` Roman Khabibov
2020-04-03 17:40 ` [Tarantool-patches] [PATCH v2 0/2] Support column addition with <ALTER TABLE> Roman Khabibov
2020-11-18 17:23 ` Alexander V. Tikhonov
2020-11-18 23:07 ` Nikita Pettik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118230724.GB23479@tarantool.org \
--to=korablev@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/2] Support column addition with <ALTER TABLE>' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox