From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v10 1/4] box/func: factor out c function entry structure
Date: Fri, 13 Nov 2020 20:56:07 +0300 [thread overview]
Message-ID: <20201113175607.GJ2021@grain> (raw)
In-Reply-To: <eb1ad741-3e1b-e0aa-203e-bebf1b4cf79c@tarantool.org>
On Thu, Nov 12, 2020 at 11:53:40PM +0100, Vladislav Shpilevoy wrote:
>
> Please, never squash refatoring and a bugfix into a single commit.
> That makes the commit not atomic, and creates problems with
> backporting such commit, which is clearly needed here.
>
> Move the bugfix to a separate commit which can be cherry-picked to
> the older versions.
Done. Resent as a separate patch. Note though that we will need to
merge it first before I'll be able to continue since this change
is blocking for the series.
next prev parent reply other threads:[~2020-11-13 17:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 15:18 [Tarantool-patches] [PATCH v10 0/4] box/cbox: implement cfunc Lua module Cyrill Gorcunov
2020-11-05 15:18 ` [Tarantool-patches] [PATCH v10 1/4] box/func: factor out c function entry structure Cyrill Gorcunov
2020-11-12 22:53 ` Vladislav Shpilevoy
2020-11-13 17:56 ` Cyrill Gorcunov [this message]
2020-11-05 15:18 ` [Tarantool-patches] [PATCH v10 2/4] module_cache: move module handling into own subsystem Cyrill Gorcunov
2020-11-12 22:54 ` Vladislav Shpilevoy
2020-11-16 9:54 ` Cyrill Gorcunov
2020-11-16 14:41 ` Cyrill Gorcunov
2020-11-05 15:18 ` [Tarantool-patches] [PATCH v10 3/4] box/cbox: implement cbox Lua module Cyrill Gorcunov
2020-11-12 22:53 ` Vladislav Shpilevoy
2020-11-16 20:26 ` Cyrill Gorcunov
2020-11-05 15:18 ` [Tarantool-patches] [PATCH v10 4/4] test: box/cfunc -- add simple module test Cyrill Gorcunov
2020-11-12 22:53 ` [Tarantool-patches] [PATCH v10 0/4] box/cbox: implement cfunc Lua module Vladislav Shpilevoy
2020-11-13 17:54 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113175607.GJ2021@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v10 1/4] box/func: factor out c function entry structure' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox