From: Nikita Pettik <korablev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] vinyl: update gh-4957-too-many-upserts test
Date: Fri, 13 Nov 2020 00:22:10 +0000 [thread overview]
Message-ID: <20201113002210.GA30202@tarantool.org> (raw)
In-Reply-To: <597d916f-21ce-d6f8-6a1a-4e6d62ae7a70@tarantool.org>
On 11 Nov 22:55, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
> On 03.11.2020 18:37, Nikita Pettik wrote:
> > After upsert rework in 5a61c4717 (#5107 issue) update operations are
> > applied consistently corresponding to upserts they belong to: if update
> > operation from single upsert fails - all update operations from that
> > upsert are skipped. But the rest of update operations related to other
> > upserts (after squashing two upserts) are applied. So let's update #4957
> > test case: now upsert operation can be processed only if it contains
> > more than BOX_UPDATE_OP_CNT_MAX (4000) operations before (before
>
> 'not more' instead of 'more'? Otherwise I don't understand.
For sure. Fixed 'can' -> 'can't'
next prev parent reply other threads:[~2020-11-13 0:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 17:37 Nikita Pettik
2020-11-11 21:55 ` Vladislav Shpilevoy
2020-11-13 0:22 ` Nikita Pettik [this message]
2020-11-16 21:24 ` Vladislav Shpilevoy
2020-11-17 19:51 ` Alexander V. Tikhonov
2020-11-17 20:26 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113002210.GA30202@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] vinyl: update gh-4957-too-many-upserts test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox