From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D050A469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 13 Nov 2020 03:22:11 +0300 (MSK)
Date: Fri, 13 Nov 2020 00:22:10 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20201113002210.GA30202@tarantool.org>
References: <2161b3318413560c0145f011a62c395b5e4fffad.1604425009.git.korablev@tarantool.org>
 <597d916f-21ce-d6f8-6a1a-4e6d62ae7a70@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <597d916f-21ce-d6f8-6a1a-4e6d62ae7a70@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] vinyl: update
	gh-4957-too-many-upserts test
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 11 Nov 22:55, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
> 
> On 03.11.2020 18:37, Nikita Pettik wrote:
> > After upsert rework in 5a61c4717 (#5107 issue) update operations are
> > applied consistently corresponding to upserts they belong to: if update
> > operation from single upsert fails - all update operations from that
> > upsert are skipped. But the rest of update operations related to other
> > upserts (after squashing two upserts) are applied. So let's update #4957
> > test case: now upsert operation can be processed only if it contains
> > more than BOX_UPDATE_OP_CNT_MAX (4000) operations before (before
> 
> 'not more' instead of 'more'? Otherwise I don't understand.

For sure. Fixed 'can' -> 'can't'