From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: roman <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] Improve json error message.
Date: Thu, 12 Nov 2020 17:03:10 +0300 [thread overview]
Message-ID: <20201112140310.GB156808@hpalx> (raw)
In-Reply-To: <7ce86fee-80a6-5863-469b-be8fc637ad80@tarantool.org>
Hi Roman, I've checked all results in gitlab-ci, and no new degradations
found [1], patch LGTM.
[1] - https://gitlab.com/tarantool/tarantool/-/pipelines/211735855
On Thu, Nov 05, 2020 at 06:44:31PM +0300, roman wrote:
> Thank you, Leonid.
>
> Alexander, can you look through the patch set, please?
>
>
> On 10.11.2020 00:22, Leonid Vasiliev wrote:
> > LGTM.
next prev parent reply other threads:[~2020-11-12 14:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 21:59 Roman Khabibov
2020-10-08 21:59 ` [Tarantool-patches] [PATCH 1/2] json: make error messages more readable Roman Khabibov
2020-10-12 8:52 ` Leonid Vasiliev
2020-10-08 21:59 ` [Tarantool-patches] [PATCH 2/2] json: print context in error mesages Roman Khabibov
2020-10-12 9:20 ` Leonid Vasiliev
2020-11-03 9:53 ` roman
2020-11-09 21:21 ` Leonid Vasiliev
2020-10-12 8:51 ` [Tarantool-patches] [PATCH 0/2] Improve json error message Leonid Vasiliev
2020-11-03 10:01 ` roman
2020-11-09 21:22 ` Leonid Vasiliev
2020-11-05 15:44 ` roman
2020-11-12 14:03 ` Alexander V. Tikhonov [this message]
2020-11-26 9:46 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112140310.GB156808@hpalx \
--to=avtikhon@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] Improve json error message.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox