Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Artem <artemreyt@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] luacheck: change global vars to local in sql-tap
Date: Wed, 11 Nov 2020 11:17:13 +0300	[thread overview]
Message-ID: <20201111081713.ealg65wtrk7x77ec@tkn_work_nb> (raw)
In-Reply-To: <20201105234659.dpwskwt5diulzphv@tkn_work_nb>

On Fri, Nov 06, 2020 at 02:47:00AM +0300, Alexander Turenko wrote:
> Thanks for the effort!
> 
> Just `luacheck .` shows the following warnings, for example:
> 
> test/sql-tap/minmax2.test.lua:64:9: setting non-standard global variable sql_search_count
> test/sql-tap/subquery.test.lua:696:9: setting non-standard global variable callcnt
> 
> It seems, `make luacheck` target does not work.
> 
>  | $ make VERBOSE=1 luacheck
>  | <...>
>  | /usr/bin/luacheck --codes --config                \
>  |     /home/alex/p/tarantool-meta/r/t-3/.luacheckrc \
>  |     /home/alex/p/tarantool-meta/r/t-3
>  | <...>
> 
> If I run luacheck this way, it does not give any warnings. This does not
> look as the problem from your patch, but it is something we should fix
> prior it.

Found problems on the luacheck side (at least it looks so) and
implemented the workaround for tarantool:

https://github.com/mpeterv/luacheck/issues/208
https://github.com/tarantool/tarantool/commit/a1d2ce9a758ac1bbf7173cf197eea3f1556b7cb4

The workaround looks a bit tricky, so I'm not sure whether it worth to
push it. I'll think around it a bit more and maybe will sent it for
review.

      parent reply	other threads:[~2020-11-11  8:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 11:25 Artem Starshov
2020-10-23 12:09 ` Sergey Bronnikov
2020-11-04 17:44   ` Artem
2020-11-05 23:46     ` Alexander Turenko
2020-11-09 14:38       ` Artem
2020-11-10 14:09         ` Sergey Bronnikov
2020-11-12 12:04           ` Artem
2020-11-11 11:53         ` Alexander Turenko
2020-11-11  8:17       ` Alexander Turenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201111081713.ealg65wtrk7x77ec@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=artemreyt@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] luacheck: change global vars to local in sql-tap' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox