From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] Raft crash on re-enablence
Date: Wed, 11 Nov 2020 00:09:08 +0300 [thread overview]
Message-ID: <20201110210908.GC25467@hpalx> (raw)
In-Reply-To: <cover.1604767356.git.v.shpilevoy@tarantool.org>
Hi Vlad, I've checked all results in gitlab-ci, and no new degradations
found [1], patch LGTM.
[1] - https://gitlab.com/tarantool/tarantool/-/pipelines/213913895
On Sat, Nov 07, 2020 at 05:45:30PM +0100, Vladislav Shpilevoy wrote:
> The patchset fixes 2 crashes related to Raft WAL write being in progress,
> when the state machine is restarted, and when it is configured to be a candidate
> with a known leader.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5506-raft-crash
> Issue: https://github.com/tarantool/tarantool/issues/5506
>
> @ChangeLog
> * Fixed a couple of crashes on various tweaks of election mode (gh-5506).
>
> Vladislav Shpilevoy (2):
> raft: fix crash on sm restart during WAL write
> raft: fix crash on candidate cfg during WAL write
>
> src/box/raft.c | 23 ++-
> .../gh-5506-election-on-off.result | 140 ++++++++++++++++++
> .../gh-5506-election-on-off.test.lua | 68 +++++++++
> test/replication/suite.cfg | 1 +
> test/replication/suite.ini | 2 +-
> 5 files changed, 225 insertions(+), 9 deletions(-)
> create mode 100644 test/replication/gh-5506-election-on-off.result
> create mode 100644 test/replication/gh-5506-election-on-off.test.lua
>
> --
> 2.21.1 (Apple Git-122.3)
>
next prev parent reply other threads:[~2020-11-10 21:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 16:45 Vladislav Shpilevoy
2020-11-07 16:45 ` [Tarantool-patches] [PATCH 1/2] raft: fix crash on sm restart during WAL write Vladislav Shpilevoy
2020-11-09 10:16 ` Serge Petrenko
2020-11-07 16:45 ` [Tarantool-patches] [PATCH 2/2] raft: fix crash on candidate cfg " Vladislav Shpilevoy
2020-11-09 10:19 ` Serge Petrenko
2020-11-09 22:42 ` Vladislav Shpilevoy
2020-11-10 7:48 ` Serge Petrenko
2020-11-10 21:09 ` Alexander V. Tikhonov [this message]
2020-11-10 22:05 ` [Tarantool-patches] [PATCH 0/2] Raft crash on re-enablence Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110210908.GC25467@hpalx \
--to=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] Raft crash on re-enablence' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox