Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] Remove autoconf tools from packages spec
Date: Mon, 9 Nov 2020 07:44:48 +0300	[thread overview]
Message-ID: <20201109044448.udxnadfej2otl4uv@tkn_work_nb> (raw)
In-Reply-To: <88989888b1a3c84f4401d2cffb9a5553fe78f9fb.1604296782.git.avtikhon@tarantool.org>

On Mon, Nov 02, 2020 at 09:24:46AM +0300, Alexander V. Tikhonov wrote:
> Remove autotools from packages spec

Let's add some meaningful prefix. I would use 'build' here.

> After cURL was changed to use cmake in commit
> 
>   2b07601922138fee02554ba69c989bee567e812e ('build: enable cmake in curl build')
> 
> there is no need to set dependencies to autoconf tools. So removed it.
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/remove-old-curl-tools
> 
>  rpm/tarantool.spec | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/rpm/tarantool.spec b/rpm/tarantool.spec
> index 489b94df8..6049d0e61 100644
> --- a/rpm/tarantool.spec
> +++ b/rpm/tarantool.spec
> @@ -26,9 +26,6 @@ Requires(pre): %{_sbindir}/useradd
>  Requires(pre): %{_sbindir}/groupadd
>  
>  # libcurl dependencies (except ones we have already).
> -BuildRequires: autoconf
> -BuildRequires: automake
> -BuildRequires: libtool
>  BuildRequires: zlib-devel
>  Requires: zlib

How about debian/control?

I see, we unable to safely remove those packages from 'deps_debian'
target in .travis.mk. However, it seems, we can do it for OSX_PKGS,
STATIC_OSX_PKGS and 'deps_freebsd'. If it is so, I would remove them.

I would also ask you to add a docbot comment or file an issue against
tarantool/doc to remove autotools from the 'building from source'
instructions for tarantool 2.6.1 and 2.7+.

NB: The issue, where it was added is
https://github.com/tarantool/doc/issues/868

      reply	other threads:[~2020-11-09  4:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02  6:24 Alexander V. Tikhonov
2020-11-09  4:44 ` Alexander Turenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201109044448.udxnadfej2otl4uv@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1] Remove autoconf tools from packages spec' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox