From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [94.100.177.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 306B7469719 for ; Mon, 9 Nov 2020 07:44:46 +0300 (MSK) Date: Mon, 9 Nov 2020 07:44:48 +0300 From: Alexander Turenko Message-ID: <20201109044448.udxnadfej2otl4uv@tkn_work_nb> References: <88989888b1a3c84f4401d2cffb9a5553fe78f9fb.1604296782.git.avtikhon@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <88989888b1a3c84f4401d2cffb9a5553fe78f9fb.1604296782.git.avtikhon@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v1] Remove autoconf tools from packages spec List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: tarantool-patches@dev.tarantool.org On Mon, Nov 02, 2020 at 09:24:46AM +0300, Alexander V. Tikhonov wrote: > Remove autotools from packages spec Let's add some meaningful prefix. I would use 'build' here. > After cURL was changed to use cmake in commit > > 2b07601922138fee02554ba69c989bee567e812e ('build: enable cmake in curl build') > > there is no need to set dependencies to autoconf tools. So removed it. > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/remove-old-curl-tools > > rpm/tarantool.spec | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/rpm/tarantool.spec b/rpm/tarantool.spec > index 489b94df8..6049d0e61 100644 > --- a/rpm/tarantool.spec > +++ b/rpm/tarantool.spec > @@ -26,9 +26,6 @@ Requires(pre): %{_sbindir}/useradd > Requires(pre): %{_sbindir}/groupadd > > # libcurl dependencies (except ones we have already). > -BuildRequires: autoconf > -BuildRequires: automake > -BuildRequires: libtool > BuildRequires: zlib-devel > Requires: zlib How about debian/control? I see, we unable to safely remove those packages from 'deps_debian' target in .travis.mk. However, it seems, we can do it for OSX_PKGS, STATIC_OSX_PKGS and 'deps_freebsd'. If it is so, I would remove them. I would also ask you to add a docbot comment or file an issue against tarantool/doc to remove autotools from the 'building from source' instructions for tarantool 2.6.1 and 2.7+. NB: The issue, where it was added is https://github.com/tarantool/doc/issues/868