From: Nikita Pettik <korablev@tarantool.org>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v4 1/5] sql: rename TK_COLUMN to TK_COLUMN_REF
Date: Thu, 5 Nov 2020 22:17:52 +0000 [thread overview]
Message-ID: <20201105221752.GB8188@tarantool.org> (raw)
In-Reply-To: <20201009134529.13212-2-roman.habibov@tarantool.org>
On 09 Oct 16:45, Roman Khabibov wrote:
> Rename TK_COLUMN used for tokens treated as a column name to
> TK_COLUMN_REF. It is needed to allow the typing of COLUMN keyword
> in <ALTER TABLE ADD COLUMN> statement.
>
> Needed for #3075
> ---
LGTM
next prev parent reply other threads:[~2020-11-05 22:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 13:45 [Tarantool-patches] [PATCH v4 0/5] Support column addition Roman Khabibov
2020-10-09 13:45 ` [Tarantool-patches] [PATCH v4 1/5] sql: rename TK_COLUMN to TK_COLUMN_REF Roman Khabibov
2020-11-05 22:17 ` Nikita Pettik [this message]
2020-10-09 13:45 ` [Tarantool-patches] [PATCH v4 2/5] sql: refactor create_table_def and parse Roman Khabibov
2020-11-05 22:17 ` Nikita Pettik
2020-11-10 12:17 ` Roman Khabibov
2020-11-17 20:23 ` Nikita Pettik
2020-11-15 11:51 ` roman
2020-10-09 13:45 ` [Tarantool-patches] [PATCH v4 3/5] schema: add box_space_field_MAX Roman Khabibov
2020-11-05 22:18 ` Nikita Pettik
2020-10-09 13:45 ` [Tarantool-patches] [PATCH v4 4/5] sql: use parser's region of "index" array Roman Khabibov
2020-11-05 22:26 ` Nikita Pettik
2020-11-10 12:18 ` Roman Khabibov
2020-11-17 20:35 ` Nikita Pettik
[not found] ` <20201009134529.13212-6-roman.habibov@tarantool.org>
2020-11-06 15:57 ` [Tarantool-patches] [PATCH v4 5/5] sql: support column addition Nikita Pettik
2020-11-10 12:18 ` Roman Khabibov
2020-11-18 16:15 ` Nikita Pettik
2020-11-15 11:51 ` roman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105221752.GB8188@tarantool.org \
--to=korablev@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4 1/5] sql: rename TK_COLUMN to TK_COLUMN_REF' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox