From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] core: fix static_alloc buffer overflow
Date: Tue, 3 Nov 2020 17:08:58 +0300 [thread overview]
Message-ID: <20201103140858.GI2339@grain> (raw)
In-Reply-To: <20201103135942.GD517@tarantool.org>
On Tue, Nov 03, 2020 at 04:59:42PM +0300, Sergey Ostanevich wrote:
> Hi!
>
> I double checked the snprintf fails only if buf is set to NULL _and_ the
> len is set to a non-zero value.
>
> So I would follow Vlad's proposal on factoring out the code to make it
> clearer.
>
> Sergos.
Looks ok to me.
next prev parent reply other threads:[~2020-11-03 14:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 15:13 Sergey Ostanevich
2020-10-23 20:06 ` Vladislav Shpilevoy
2020-10-29 22:56 ` Vladislav Shpilevoy
2020-10-30 7:07 ` Cyrill Gorcunov
2020-10-31 16:33 ` Vladislav Shpilevoy
2020-11-02 13:19 ` Sergey Ostanevich
2020-11-02 21:09 ` Vladislav Shpilevoy
2020-11-02 21:18 ` Cyrill Gorcunov
2020-11-02 21:43 ` Vladislav Shpilevoy
2020-11-02 21:47 ` Cyrill Gorcunov
2020-11-03 13:59 ` Sergey Ostanevich
2020-11-03 14:08 ` Cyrill Gorcunov [this message]
2020-11-03 22:59 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103140858.GI2339@grain \
--to=gorcunov@gmail.com \
--cc=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] core: fix static_alloc buffer overflow' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox