From: Nikita Pettik <korablev@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 0/4] test: stabilize testing with issue #5141
Date: Sun, 1 Nov 2020 21:57:35 +0000 [thread overview]
Message-ID: <20201101215735.GA23655@tarantool.org> (raw)
In-Reply-To: <cover.1604040010.git.avtikhon@tarantool.org>
On 30 Oct 09:59, Alexander V. Tikhonov wrote:
> To stabilize testing with issue #5141 the following steps had to be
> done:
Сорри что влезаю, но что тут происходит? Парни, если тест сломан,
его надо нормально починить, а не костылить слипами и тд. Там есть
одна явная бага (5436), ей надо заняться. Я просто вижу какое-то насилование
винильных тестов, это по-другому и не назовешь. Если надо срочно починить CI -
просто отрубите этот тест (с апсертами) и все. Я постараюсь им заняться в
ближайшее (и видимо свободное) время.
> - Prepare tests - add test-run filter on box.snapshot error message:
>
> 'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'
>
> to avoid of printing changing data in results file to be able to use
> its checksums in fragile list of test-run to rerun it as flaky issue.
>
> - Create the stable reproducer for the issue #5141 as new standalone
> test vinyl/gh-5141-invalid-vylog-file.test.lua.
А зачем репродюсер тут? Я же уже и так открыл 5436 и вынес минимальный
репро туда.
next prev parent reply other threads:[~2020-11-01 21:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 6:59 Alexander V. Tikhonov
2020-10-30 6:59 ` [Tarantool-patches] [PATCH v1 1/4] test: add test filter for box.snapshot Alexander V. Tikhonov
2020-10-30 7:00 ` [Tarantool-patches] [PATCH v1 2/4] test: create reproducer for #5141 Alexander V. Tikhonov
2020-10-30 7:00 ` [Tarantool-patches] [PATCH v1 3/4] test: fix flaky vinyl/gh-4957-too-many-upserts Alexander V. Tikhonov
2020-10-30 7:00 ` [Tarantool-patches] [PATCH v1 4/4] test: fix hanging of vinyl/gh.test.lua Alexander V. Tikhonov
2020-11-01 8:53 ` [Tarantool-patches] [PATCH v1 0/4] test: stabilize testing with issue #5141 Kirill Yukhin
2020-11-01 21:57 ` Nikita Pettik [this message]
2020-11-02 7:33 ` Alexander V. Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201101215735.GA23655@tarantool.org \
--to=korablev@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 0/4] test: stabilize testing with issue #5141' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox