Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v1 3/4] test: fix flaky vinyl/gh-4957-too-many-upserts
Date: Fri, 30 Oct 2020 10:00:01 +0300	[thread overview]
Message-ID: <1b54aef8c8517ac18a6ecbbacb635684d6e873d5.1604040010.git.avtikhon@tarantool.org> (raw)
In-Reply-To: <cover.1604040010.git.avtikhon@tarantool.org>

Added restart the current server to resolve the issue #5141 which
reproduced in test:

  vinyl/gh-5141-invalid-vylog-file.test.lua

Added test-run filter on box.snapshot error message:

  'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'

to avoid of printing changing data in results file to be able to use
its checksums in fragile list of test-run to rerun it as flaky issue.

Part of #5141
---
 test/vinyl/gh-4957-too-many-upserts.result   | 17 +++++++++++++++++
 test/vinyl/gh-4957-too-many-upserts.test.lua | 11 +++++++++++
 2 files changed, 28 insertions(+)

diff --git a/test/vinyl/gh-4957-too-many-upserts.result b/test/vinyl/gh-4957-too-many-upserts.result
index 67292f0f8..c942e62c8 100644
--- a/test/vinyl/gh-4957-too-many-upserts.result
+++ b/test/vinyl/gh-4957-too-many-upserts.result
@@ -1,4 +1,13 @@
 -- test-run result file version 2
+test_run = require('test_run').new()
+ | ---
+ | ...
+test_run:cmd("push filter 'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'" .. \
+             "to 'Invalid VYLOG file: Slice <NUM> deleted but not registered'")
+ | ---
+ | - true
+ | ...
+
 s = box.schema.create_space('test', {engine = 'vinyl'})
  | ---
  | ...
@@ -90,3 +99,11 @@ fiber.sleep(0.01)
 s:drop()
  | ---
  | ...
+
+-- restart the current server to resolve the issue #5141
+-- which reproduced in test:
+--   vinyl/gh-5141-invalid-vylog-file.test.lua
+test_run:cmd("restart server default with cleanup=True")
+ | 
+
+
diff --git a/test/vinyl/gh-4957-too-many-upserts.test.lua b/test/vinyl/gh-4957-too-many-upserts.test.lua
index e5adfe41c..572540a4c 100644
--- a/test/vinyl/gh-4957-too-many-upserts.test.lua
+++ b/test/vinyl/gh-4957-too-many-upserts.test.lua
@@ -1,3 +1,7 @@
+test_run = require('test_run').new()
+test_run:cmd("push filter 'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'" .. \
+             "to 'Invalid VYLOG file: Slice <NUM> deleted but not registered'")
+
 s = box.schema.create_space('test', {engine = 'vinyl'})
 pk = s:create_index('pk')
 s:insert{1, 1}
@@ -36,3 +40,10 @@ box.snapshot()
 fiber.sleep(0.01)
 
 s:drop()
+
+-- restart the current server to resolve the issue #5141
+-- which reproduced in test:
+--   vinyl/gh-5141-invalid-vylog-file.test.lua
+test_run:cmd("restart server default with cleanup=True")
+
+
-- 
2.25.1

  parent reply	other threads:[~2020-10-30  7:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30  6:59 [Tarantool-patches] [PATCH v1 0/4] test: stabilize testing with issue #5141 Alexander V. Tikhonov
2020-10-30  6:59 ` [Tarantool-patches] [PATCH v1 1/4] test: add test filter for box.snapshot Alexander V. Tikhonov
2020-10-30  7:00 ` [Tarantool-patches] [PATCH v1 2/4] test: create reproducer for #5141 Alexander V. Tikhonov
2020-10-30  7:00 ` Alexander V. Tikhonov [this message]
2020-10-30  7:00 ` [Tarantool-patches] [PATCH v1 4/4] test: fix hanging of vinyl/gh.test.lua Alexander V. Tikhonov
2020-11-01  8:53 ` [Tarantool-patches] [PATCH v1 0/4] test: stabilize testing with issue #5141 Kirill Yukhin
2020-11-01 21:57 ` Nikita Pettik
2020-11-02  7:33   ` Alexander V. Tikhonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b54aef8c8517ac18a6ecbbacb635684d6e873d5.1604040010.git.avtikhon@tarantool.org \
    --to=avtikhon@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 3/4] test: fix flaky vinyl/gh-4957-too-many-upserts' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox