From: Kirill Yukhin <kyukhin@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 0/3] implement default compiler build with Werror
Date: Sun, 1 Nov 2020 08:48:19 +0000 [thread overview]
Message-ID: <20201101084819.vkrkzzuotqdmy3o6@tarantool.org> (raw)
In-Reply-To: <cover.1603207315.git.avtikhon@tarantool.org>
Hello,
On 20 окт 18:40, Alexander V. Tikhonov wrote:
> To implement default compiler build with Werror decided to use
> gcc-4.8.5 on CentOS 7. Also decided to use packages build process
> for it. 'ENABLE_WERROR' flag was added to packages build options spec
> file to enable Werror in packages builds. Also fixed issue with
> test/unit tests build which was found building with Werror flag.
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4941-gcc-old
> Issue: https://github.com/tarantool/tarantool/issues/4941
LGTM.
I've checked your patchset into 1.10, 2.5, 2.6 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-11-01 8:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 15:40 Alexander V. Tikhonov
2020-10-20 15:40 ` [Tarantool-patches] [PATCH v2 1/3] build: fix Werror warning in test/unit:fiber*.c* Alexander V. Tikhonov
2020-10-20 15:40 ` [Tarantool-patches] [PATCH v1 2/3] build: add Werror flag on packages builds Alexander V. Tikhonov
2020-10-20 15:40 ` [Tarantool-patches] [PATCH v1 3/3] gitlab-ci: test default gcc on CentOS 7 Alexander V. Tikhonov
2020-11-01 8:48 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201101084819.vkrkzzuotqdmy3o6@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 0/3] implement default compiler build with Werror' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox