From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5590F469719 for ; Sun, 1 Nov 2020 11:48:20 +0300 (MSK) Date: Sun, 1 Nov 2020 08:48:19 +0000 From: Kirill Yukhin Message-ID: <20201101084819.vkrkzzuotqdmy3o6@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v1 0/3] implement default compiler build with Werror List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: tarantool-patches@dev.tarantool.org Hello, On 20 окт 18:40, Alexander V. Tikhonov wrote: > To implement default compiler build with Werror decided to use > gcc-4.8.5 on CentOS 7. Also decided to use packages build process > for it. 'ENABLE_WERROR' flag was added to packages build options spec > file to enable Werror in packages builds. Also fixed issue with > test/unit tests build which was found building with Werror flag. > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4941-gcc-old > Issue: https://github.com/tarantool/tarantool/issues/4941 LGTM. I've checked your patchset into 1.10, 2.5, 2.6 and master. -- Regards, Kirill Yukhin