From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Aleksandr Lyapunov <alyapunov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] Fix transaction manager
Date: Thu, 22 Oct 2020 19:42:44 +0300 [thread overview]
Message-ID: <20201022164244.GA667662@hpalx> (raw)
In-Reply-To: <1603382553-5570-1-git-send-email-alyapunov@tarantool.org>
Hi Aleksandr, thanks for the patch. As I see it really fixed the issue
[1], and no new degradations occurred. Patchset LGTM.
[1] - https://gitlab.com/tarantool/tarantool/-/pipelines/206407310
On Thu, Oct 22, 2020 at 07:02:31PM +0300, Aleksandr Lyapunov wrote:
> There was two issues:
> * https://github.com/tarantool/tarantool/issues/5423
> * tx_man test faild on OSX builds
>
> Both problems are fixed now.
>
> Branch: alyapunov/gh-5423-dirty-tuple-unref
>
> Aleksandr Lyapunov (2):
> memtx: fix a bug in unlinking story lists
> memtx: fix a bug in TX that caused deletion of a durty tuple
>
> src/box/memtx_space.c | 1 +
> src/box/memtx_tx.c | 67 +++++++++++++++++++++++++++++++++++++++---------
> test/box/tx_man.result | 43 +++++++++++++++++++++++++++++++
> test/box/tx_man.test.lua | 16 ++++++++++++
> 4 files changed, 115 insertions(+), 12 deletions(-)
>
> --
> 2.7.4
>
prev parent reply other threads:[~2020-10-22 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 16:02 Aleksandr Lyapunov
2020-10-22 16:02 ` [Tarantool-patches] [PATCH 1/2] memtx: fix a bug in unlinking story lists Aleksandr Lyapunov
2020-10-22 16:02 ` [Tarantool-patches] [PATCH 2/2] memtx: fix a bug in TX that caused deletion of a durty tuple Aleksandr Lyapunov
2020-10-22 16:42 ` Alexander V. Tikhonov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022164244.GA667662@hpalx \
--to=avtikhon@tarantool.org \
--cc=alyapunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] Fix transaction manager' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox