From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] Minor fixes for new LuaJIT extention library
Date: Wed, 21 Oct 2020 19:17:00 +0300 [thread overview]
Message-ID: <20201021161700.GA356651@hpalx> (raw)
In-Reply-To: <cover.1602931403.git.skaplun@tarantool.org>
Hi Sergey, Ive checked tests results of your patchset, and no new
degradations found [1]. Patchset LGTM.
[1] - https://gitlab.com/tarantool/tarantool/-/pipelines/205179305
On Sat, Oct 17, 2020 at 02:13:29PM +0300, Sergey Kaplun wrote:
> This patchset consists from 2 parts:
> 1) Provide corresponding new LuaJIT header within tarantool at install.
> 2) Add missing public C API symbols from the new lib into exports.h
>
> Branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-5187-luajit-include-headers
>
> CI is red, but fails related to replication tests or at osx_* jobs
> (see also https://github.com/tarantool/tarantool/issues/5423).
> CI: https://gitlab.com/tarantool/tarantool/-/pipelines/203892776
>
> Sergey Kaplun (2):
> build: provide missing LuaJIT lmisclib.h header
> lua: add missing LuaJIT export symbols
>
> FreeBSD/databases/tarantool/pkg-plist | 1 +
> cmake/luajit.cmake | 2 +-
> rpm/tarantool.spec | 1 +
> src/exports.h | 2 ++
> 4 files changed, 5 insertions(+), 1 deletion(-)
>
> --
> 2.28.0
>
prev parent reply other threads:[~2020-10-21 16:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 11:13 Sergey Kaplun
2020-10-17 11:13 ` [Tarantool-patches] [PATCH 1/2] build: provide missing LuaJIT lmisclib.h header Sergey Kaplun
2020-10-18 19:19 ` Igor Munkin
2020-10-19 4:55 ` Sergey Kaplun
2020-10-20 12:07 ` Sergey Ostanevich
2020-10-17 11:13 ` [Tarantool-patches] [PATCH 2/2] lua: add missing LuaJIT export symbols Sergey Kaplun
2020-10-18 18:43 ` Igor Munkin
2020-10-19 4:57 ` Sergey Kaplun
2020-10-20 12:09 ` Sergey Ostanevich
2020-10-20 13:03 ` Sergey Kaplun
2020-10-21 16:08 ` [Tarantool-patches] [PATCH 0/2] Minor fixes for new LuaJIT extention library Alexander Turenko
2020-10-21 16:17 ` Alexander V. Tikhonov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021161700.GA356651@hpalx \
--to=avtikhon@tarantool.org \
--cc=skaplun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] Minor fixes for new LuaJIT extention library' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox