Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun <skaplun@tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
	Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/2] lua: add missing LuaJIT export symbols
Date: Mon, 19 Oct 2020 07:57:15 +0300	[thread overview]
Message-ID: <20201019045715.GD1834@root> (raw)
In-Reply-To: <20201018184316.GD5396@tarantool.org>

Igor,

Thanks for the review! I've updated commit message considering your
comment here. Branch is force pushed.

On 18.10.20, Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! LGTM, except a single nit.
> 
> On 17.10.20, Sergey Kaplun wrote:
> > Since LuaJIT provides public C API symbols that are used in the final
> > executable, the linker may not just throw it away.
> > Nevertheless for future compatibility all symbols from LuaJIT public API
> > should be additionaly added at exports.h file.
> > 
> > Follows up tarantool/tarantool#5187
> 
> Minor: You don't need to use full repo reference here.
> 
> > ---
> >  src/exports.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> 
> <snipped>
> 
> > -- 
> > 2.28.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun

  reply	other threads:[~2020-10-19  4:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-17 11:13 [Tarantool-patches] [PATCH 0/2] Minor fixes for new LuaJIT extention library Sergey Kaplun
2020-10-17 11:13 ` [Tarantool-patches] [PATCH 1/2] build: provide missing LuaJIT lmisclib.h header Sergey Kaplun
2020-10-18 19:19   ` Igor Munkin
2020-10-19  4:55     ` Sergey Kaplun
2020-10-20 12:07       ` Sergey Ostanevich
2020-10-17 11:13 ` [Tarantool-patches] [PATCH 2/2] lua: add missing LuaJIT export symbols Sergey Kaplun
2020-10-18 18:43   ` Igor Munkin
2020-10-19  4:57     ` Sergey Kaplun [this message]
2020-10-20 12:09       ` Sergey Ostanevich
2020-10-20 13:03         ` Sergey Kaplun
2020-10-21 16:08 ` [Tarantool-patches] [PATCH 0/2] Minor fixes for new LuaJIT extention library Alexander Turenko
2020-10-21 16:17 ` Alexander V. Tikhonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201019045715.GD1834@root \
    --to=skaplun@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=imun@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 2/2] lua: add missing LuaJIT export symbols' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox