Re: [Tarantool-patches] [PATCH 2/3] misc: add lib_misc.c to all .bat files

[Sergey Kaplun <skaplun@tarantool.org>]

Igor,

Thanks for the review! I've updated commit message considering your
comments. Branch is force pushed.

On 18.10.20, Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! The fix looks quite clear, but I have no way to
> check it by myself. This breaks nothing, so LGTM, but please consider my
> nits below.
> 
> On 16.10.20, Sergey Kaplun wrote:

<snipped>

> 
> Minor: I believe <build> is much better here instead of <misc>.

Yes, updated.

> 
> >     
> >     For become symbols exportable at several building systems
> 
> Typo: s/For become/To make/.

Yep, thanks!

> 
> >     (namely mvsc, xedk, xb1) LuaJIT defines LUA_BUILD_AS_DLL at
> >     corresponding bat files.  When this macro is defined, the definition of
> 
> Typo: Doubled whitespace above.

Thanks again!

> 
> >     LUA_API macro depends on LUA_CORE and LUA_LIB macros (see luaconf.h). If
> >     defined(LUA_CORE) or defined(LUA_LIB) then LUA_API macro is defined as
> >     __declspec(dllexport). Otherwise, it defined as __declspec(dllimport).
> 
> Typo: s/it defined/it is defined/.

Fixed.

> 
> >     
> >     This patch consists from two parts.
> >     
> >     First of all it adds lib_misc.c to ALL_LIB in .bat files
> >     for specific building systems.
> >     
> >     Secondly, this patch also adds definition of LUA_CORE macro at the top
> >     of lj_mapi.c file to make corresponding symbols exportable for systems
> >     described above.
> >     
> >     Follows up tarantool/tarantool#5187
> > 
> 
> <snipped>
> 
> > ===================================================================
> > 
> > -- 
> > Best regards,
> > Sergey Kaplun
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun