From: Igor Munkin <imun@tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/3] misc: add lmisclib.h to lua.hpp header
Date: Sun, 18 Oct 2020 19:39:06 +0300 [thread overview]
Message-ID: <20201018163906.GA5396@tarantool.org> (raw)
In-Reply-To: <dcd8483d540f1d66ffc5a95dd7d0f624190bde26.1602859961.git.skaplun@tarantool.org>
Sergey,
Thanks for the patch! LGTM, no questions.
On 16.10.20, Sergey Kaplun wrote:
> This patch adds missing lmisclib.h header to C++ wrapper
> for LuaJIT header files as part of extended public API.
>
> Follows up tarantool/tarantool#5187
> ---
> src/lua.hpp | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/lua.hpp b/src/lua.hpp
> index 07e9002..56ae165 100644
> --- a/src/lua.hpp
> +++ b/src/lua.hpp
> @@ -5,5 +5,6 @@ extern "C" {
> #include "lauxlib.h"
> #include "lualib.h"
> #include "luajit.h"
> +#include "lmisclib.h"
> }
>
> --
> 2.28.0
>
--
Best regards,
IM
next prev parent reply other threads:[~2020-10-18 16:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 15:26 [Tarantool-patches] [PATCH 0/3] LuaJIT misclib minor improvements Sergey Kaplun
2020-10-16 15:26 ` [Tarantool-patches] [PATCH 1/3] misc: add lmisclib.h to lua.hpp header Sergey Kaplun
2020-10-18 16:39 ` Igor Munkin [this message]
2020-10-20 12:25 ` Sergey Ostanevich
2020-10-16 15:26 ` [Tarantool-patches] [PATCH 2/3] misc: add lib_misc.c to all .bat files Sergey Kaplun
2020-10-16 19:49 ` Sergey Kaplun
2020-10-18 18:19 ` Igor Munkin
2020-10-19 4:35 ` Sergey Kaplun
2020-10-20 12:29 ` Sergey Ostanevich
2020-10-16 15:26 ` [Tarantool-patches] [PATCH 3/3] misc: fix linking when LUA_BUILD_AS_DLL is defined Sergey Kaplun
2020-10-16 19:51 ` Sergey Kaplun
2020-10-18 18:37 ` [Tarantool-patches] [PATCH 0/3] LuaJIT misclib minor improvements Igor Munkin
2020-10-19 4:27 ` Sergey Kaplun
2020-10-20 15:58 ` Alexander V. Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201018163906.GA5396@tarantool.org \
--to=imun@tarantool.org \
--cc=skaplun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/3] misc: add lmisclib.h to lua.hpp header' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox