* [Tarantool-patches] [PATCH] module api: fix asan failures in test
@ 2020-10-16 16:57 Timur Safin
2020-10-16 17:17 ` Alexander V. Tikhonov
2020-10-17 5:17 ` Kirill Yukhin
0 siblings, 2 replies; 3+ messages in thread
From: Timur Safin @ 2020-10-16 16:57 UTC (permalink / raw)
To: alexander.turenko, avtikhon; +Cc: tarantool-patches
Adding forgotten resource cleanup to the
`test_tuple_validate_formatted` test, to make ASAN
happy again.
Closes #5432
Relates to #5384
---
Branch is tsafin/gh-5432-module-api-asan-fix
test/app-tap/module_api.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/test/app-tap/module_api.c b/test/app-tap/module_api.c
index 7ca0c9a15..ce7fa2353 100644
--- a/test/app-tap/module_api.c
+++ b/test/app-tap/module_api.c
@@ -2327,6 +2327,8 @@ test_tuple_validate_formatted(lua_State *L)
assert(format);
valid = box_tuple_validate(tuple, format) == 0;
+ box_tuple_format_unref(format);
+ box_key_def_delete(key_defs[0]);
}
lua_pushboolean(L, valid);
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Tarantool-patches] [PATCH] module api: fix asan failures in test
2020-10-16 16:57 [Tarantool-patches] [PATCH] module api: fix asan failures in test Timur Safin
@ 2020-10-16 17:17 ` Alexander V. Tikhonov
2020-10-17 5:17 ` Kirill Yukhin
1 sibling, 0 replies; 3+ messages in thread
From: Alexander V. Tikhonov @ 2020-10-16 17:17 UTC (permalink / raw)
To: Timur Safin; +Cc: tarantool-patches
Hi Timur, thanks for the patch. As I see in results [1] it really fixed the
issue. Patch LGTM.
[1] - https://gitlab.com/tarantool/tarantool/-/jobs/795704534#L4636
On Fri, Oct 16, 2020 at 07:57:28PM +0300, Timur Safin wrote:
> Adding forgotten resource cleanup to the
> `test_tuple_validate_formatted` test, to make ASAN
> happy again.
>
> Closes #5432
> Relates to #5384
> ---
>
> Branch is tsafin/gh-5432-module-api-asan-fix
>
> test/app-tap/module_api.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/test/app-tap/module_api.c b/test/app-tap/module_api.c
> index 7ca0c9a15..ce7fa2353 100644
> --- a/test/app-tap/module_api.c
> +++ b/test/app-tap/module_api.c
> @@ -2327,6 +2327,8 @@ test_tuple_validate_formatted(lua_State *L)
> assert(format);
>
> valid = box_tuple_validate(tuple, format) == 0;
> + box_tuple_format_unref(format);
> + box_key_def_delete(key_defs[0]);
> }
> lua_pushboolean(L, valid);
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Tarantool-patches] [PATCH] module api: fix asan failures in test
2020-10-16 16:57 [Tarantool-patches] [PATCH] module api: fix asan failures in test Timur Safin
2020-10-16 17:17 ` Alexander V. Tikhonov
@ 2020-10-17 5:17 ` Kirill Yukhin
1 sibling, 0 replies; 3+ messages in thread
From: Kirill Yukhin @ 2020-10-17 5:17 UTC (permalink / raw)
To: Timur Safin; +Cc: tarantool-patches, alexander.turenko
Hello,
On 16 окт 19:57, Timur Safin wrote:
> Adding forgotten resource cleanup to the
> `test_tuple_validate_formatted` test, to make ASAN
> happy again.
>
> Closes #5432
> Relates to #5384
LGTM.
I've checked your patch into master.
--
Regards, Kirill Yukhin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-17 5:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16 16:57 [Tarantool-patches] [PATCH] module api: fix asan failures in test Timur Safin
2020-10-16 17:17 ` Alexander V. Tikhonov
2020-10-17 5:17 ` Kirill Yukhin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox