From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] raft: fix crash when leader resigned from its role
Date: Fri, 16 Oct 2020 10:16:13 +0300 [thread overview]
Message-ID: <20201016071613.hxlt4f5j4k7uuywd@tarantool.org> (raw)
In-Reply-To: <470cb12f9bcce14409c28de104e4e442fc9d37d2.1602801983.git.v.shpilevoy@tarantool.org>
Hello,
On 16 окт 00:47, Vladislav Shpilevoy wrote:
> Nodes with disabled Raft keep listening for Raft events and
> persist them. To be able to quickly enroll into the process if
> they are configured to be candidates.
>
> The same for the voter nodes - they can't be a leader, but watch
> and persist all what is happening.
>
> However when a leader resigned from its role, the voter and
> disabled nodes tried to start a new election round, even though
> they were not supposed to. That led to a crash, and is fixed in
> this patch.
>
> Closes #5426
> ---
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5426-raft-crash-on-election-toogle
> Issue: https://github.com/tarantool/tarantool/issues/5426
LGTM. I've checked your patch into master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-10-16 7:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 22:47 Vladislav Shpilevoy
2020-10-16 7:16 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016071613.hxlt4f5j4k7uuywd@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] raft: fix crash when leader resigned from its role' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox