From: Alexander Turenko <alexander.turenko@tarantool.org> To: Timur Safin <tsafin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Subject: Re: [Tarantool-patches] [PATCH 2.X v4 0/4] module api: extend for external merger Lua module Date: Fri, 16 Oct 2020 09:10:47 +0300 [thread overview] Message-ID: <20201016061047.eduhu4ul7fkkabm4@tkn_work_nb> (raw) In-Reply-To: <cover.1602629628.git.tsafin@tarantool.org> The patchset looks good to me in general, however I agree with Vlad that it would be good to polish it if we would not have so tight timeline. I made several changes before pushing: - 'module api: box_ibuf_* wrappers' is applied first (we need it to use <box_ibuf_t> for luaT_toibuf() later). - Use <box_ibuf_t> in luaT_toibuf(). And so moved the box/ibuf.h header before lua/utils.h in the list of the API headers. - Marked the last commit as 'Closes #5384' instead of 'Part of #5384'. - Moved the luaL_iscallable 1.10 backport as first to form the proper chain of 'part of', 'part of', ... 'closes'. - Found and fixed 'unused variable' warnings on module_api.c on RelWithDebInfo build. Pushed to master, 2.5, 2.4 and 1.10. WBR, Alexander Turenko.
prev parent reply other threads:[~2020-10-16 6:10 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-13 23:01 Timur Safin 2020-10-13 23:01 ` [Tarantool-patches] [PATCH 2.X v4 1/4] module api: export box_tuple_validate Timur Safin 2020-10-15 21:38 ` Alexander Turenko 2020-10-15 21:47 ` Timur Safin 2020-10-15 22:03 ` Vladislav Shpilevoy 2020-10-13 23:01 ` [Tarantool-patches] [PATCH 2.X v4 2/4] module api: export box_key_def_dup Timur Safin 2020-10-13 23:01 ` [Tarantool-patches] [PATCH 2.X v4 3/4] module api: introduced luaT_toibuf instead of luaL_checkibuf Timur Safin 2020-10-14 3:50 ` Alexander Turenko 2020-10-15 21:07 ` Timur Safin 2020-10-15 22:04 ` Vladislav Shpilevoy 2020-10-13 23:01 ` [Tarantool-patches] [PATCH 2.X v4 4/4] module api: box_ibuf_* wrappers Timur Safin 2020-10-14 3:31 ` Alexander Turenko 2020-10-15 21:35 ` Timur Safin 2020-10-15 21:42 ` Alexander Turenko 2020-10-15 21:44 ` Timur Safin 2020-10-15 21:52 ` Alexander Turenko 2020-10-15 22:07 ` Vladislav Shpilevoy 2020-10-15 22:20 ` Alexander Turenko 2020-10-15 22:27 ` Timur Safin 2020-10-15 22:47 ` Alexander Turenko 2020-10-15 22:37 ` Alexander Turenko 2020-10-15 22:48 ` Alexander Turenko 2020-10-15 22:39 ` [Tarantool-patches] [PATCH 2.X v4.1] " Timur Safin 2020-10-16 6:10 ` Alexander Turenko [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201016061047.eduhu4ul7fkkabm4@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=tsafin@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 2.X v4 0/4] module api: extend for external merger Lua module' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox