From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 00/16] module api: extend for external key_def Lua module
Date: Fri, 16 Oct 2020 09:05:52 +0300 [thread overview]
Message-ID: <20201016060552.yfk64ogajv3m3ql6@tkn_work_nb> (raw)
In-Reply-To: <20201015131957.sabrixdqbkksuzwg@tkn_work_nb>
On Thu, Oct 15, 2020 at 04:19:58PM +0300, Alexander Turenko wrote:
> Updated.
>
> Changes from v3 to the final version (I hope it is final):
>
> - Fixed sorting of the box region functions in src/exports.h.
> - Added forgotten API_EXPORT for box_region_truncate().
> - Added a comment for luaT_tuple_encode_table() reference in the Lua registry.
> - Added the <size_t *key_size_ptr> parameter to box_key_def_validate_key() and
> box_key_def_validate_full_key().
> - Fixed API comments for key_def functions with mention of the diagnostics
> area.
> - Set a memory error to the diagnostics area for box_region_*alloc() functions.
List of changes that I made before pushing:
- test_iscdata(): fixed negative index testing:
| - lua_pushboolean(L, res == exp);
| + lua_pushboolean(L, ok);
- Found and fixed 'unused variable' warnings on module_api.c on
RelWithDebInfo build.
Pushed to master, 2.5, 2.4 and 1.10.
Many thanks to Vlad for help with designing, eagle eyes and fast
responses.
WBR, Alexander Turenko.
next prev parent reply other threads:[~2020-10-16 6:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 23:23 Alexander Turenko
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 01/16] module api: get rid of typedef redefinitions Alexander Turenko
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 02/16] module api: expose box region Alexander Turenko
2020-10-14 23:41 ` Vladislav Shpilevoy
2020-10-15 13:17 ` Alexander Turenko
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 03/16] module api/lua: add luaL_iscdata() function Alexander Turenko
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 04/16] lua: factor out tuple encoding from luaT_tuple_new Alexander Turenko
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 05/16] lua: don't raise a Lua error from luaT_tuple_new() Alexander Turenko
2020-10-14 23:41 ` Vladislav Shpilevoy
2020-10-15 13:17 ` Alexander Turenko
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 06/16] module api/lua: add luaT_tuple_encode() Alexander Turenko
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 07/16] module api/lua: expose luaT_tuple_new() Alexander Turenko
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 08/16] module api/lua: add API_EXPORT to tuple functions Alexander Turenko
2020-10-14 23:41 ` Vladislav Shpilevoy
2020-10-15 2:35 ` Alexander Turenko
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 09/16] module api: add API_EXPORT to key_def functions Alexander Turenko
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 10/16] module api: add box_key_def_new_v2() Alexander Turenko
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 11/16] module api: add box_key_def_dump_parts() Alexander Turenko
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 12/16] module api: expose box_key_def_validate_tuple() Alexander Turenko
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 13/16] module api: expose box_key_def_merge() Alexander Turenko
2020-10-14 23:41 ` Vladislav Shpilevoy
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 14/16] module api: expose box_key_def_extract_key() Alexander Turenko
2020-10-14 23:41 ` Vladislav Shpilevoy
2020-10-15 2:39 ` Alexander Turenko
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 15/16] module api: add box_key_def_validate_key() Alexander Turenko
2020-10-14 23:41 ` Vladislav Shpilevoy
2020-10-15 13:18 ` Alexander Turenko
2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 16/16] module api: add box_key_def_validate_full_key() Alexander Turenko
2020-10-14 23:41 ` [Tarantool-patches] [PATCH v3 00/16] module api: extend for external key_def Lua module Vladislav Shpilevoy
2020-10-15 3:09 ` Alexander Turenko
2020-10-15 13:19 ` Alexander Turenko
2020-10-16 6:05 ` Alexander Turenko [this message]
2020-10-15 20:12 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016060552.yfk64ogajv3m3ql6@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 00/16] module api: extend for external key_def Lua module' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox