From: Igor Munkin <imun@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: add OSX 13 to testing
Date: Thu, 15 Oct 2020 18:45:25 +0300 [thread overview]
Message-ID: <20201015154525.GF32659@tarantool.org> (raw)
In-Reply-To: <09afd52172ef5282b97f18ce62b07646d6690681.1602623910.git.avtikhon@tarantool.org>
Sasha,
Thanks for the patch! The changes are LGTM, except a single nit.
On 14.10.20, Alexander V. Tikhonov wrote:
> Restored OSX 13 testing to pass homebrew commit criteria.
> Added MACOSX_DEPLOYMENT_TARGET=10.13 environment.
Typo: s/environment/environment variable/.
Side note: it would be nice to describe the issue fixed by this variable
right in commit message, but I see the related info in the mentioned
ticket, so feel free to ignore.
>
> Closes #5374
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/mac-13
> Issue: https://github.com/tarantool/tarantool/issues/5374
>
> .gitlab-ci.yml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
<snipped>
> --
> 2.25.1
>
--
Best regards,
IM
next prev parent reply other threads:[~2020-10-15 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 21:21 Alexander V. Tikhonov
2020-10-15 15:45 ` Igor Munkin [this message]
2020-10-16 8:25 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015154525.GF32659@tarantool.org \
--to=imun@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] gitlab-ci: add OSX 13 to testing' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox