From: Alexander Turenko <alexander.turenko@tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v3 02/16] module api: expose box region Date: Thu, 15 Oct 2020 16:17:16 +0300 [thread overview] Message-ID: <20201015131716.4wmw66boyslayssy@tkn_work_nb> (raw) In-Reply-To: <c7cf846c-030b-42fd-c6d6-268cf8d2964e@tarantool.org> On Thu, Oct 15, 2020 at 01:41:41AM +0200, Vladislav Shpilevoy wrote: > Thanks for the patch! > > See 3 comments below. > > > diff --git a/src/exports.h b/src/exports.h > > index 6d8303180..7861bb529 100644 > > --- a/src/exports.h > > +++ b/src/exports.h > > @@ -218,6 +218,10 @@ EXPORT(fiber_is_cancelled) > > EXPORT(fiber_join) > > EXPORT(fiber_new) > > EXPORT(fiber_new_ex) > > +EXPORT(box_region_aligned_alloc) > > +EXPORT(box_region_alloc) > > +EXPORT(box_region_truncate) > > +EXPORT(box_region_used) > > 1. Could you please keep the function list sorted? > 'b' < 'f'. Ouch, sorry for this. Fixed on the branch. > > 2. Don't we want to also export reserve/aligned_reserve, > while we are here? They are useful when need to write data > knowing its maximal size, and then call alloc() with the > exact size in the end. I don't like to do something in a hurry and without proper documentation and test. It surely worth it, so included into my backlog. > > > diff --git a/src/lib/core/fiber.h b/src/lib/core/fiber.h > > index 16ee9f414..a3014cc0a 100644 > > --- a/src/lib/core/fiber.h > > +++ b/src/lib/core/fiber.h > > @@ -386,6 +386,82 @@ struct slab_cache; > > +/** > > + * Allocate size bytes from the box region. > > + * > > + * Don't use this function to allocate a memory block for a value > > + * or array of values of a type with alignment requirements. A > > + * violation of alignment requirements leads to undefined > > + * behaviour. > > + */ > > +API_EXPORT void * > > +box_region_alloc(size_t size); > > + > > +/** > > + * Allocate size bytes from the box region with given alignment. > > + * > > + * Alignment must be a power of 2. > > + */ > > +API_EXPORT void * > > +box_region_aligned_alloc(size_t size, size_t alignment); > > + > > +/** > > + * Truncate the box region to the given size. > > + */ > > +void > > 3. + API_EXPORT. Fixed on the branches. > > > +box_region_truncate(size_t size); > > + > > /** \endcond public */
next prev parent reply other threads:[~2020-10-15 13:16 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-12 23:23 [Tarantool-patches] [PATCH v3 00/16] module api: extend for external key_def Lua module Alexander Turenko 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 01/16] module api: get rid of typedef redefinitions Alexander Turenko 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 02/16] module api: expose box region Alexander Turenko 2020-10-14 23:41 ` Vladislav Shpilevoy 2020-10-15 13:17 ` Alexander Turenko [this message] 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 03/16] module api/lua: add luaL_iscdata() function Alexander Turenko 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 04/16] lua: factor out tuple encoding from luaT_tuple_new Alexander Turenko 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 05/16] lua: don't raise a Lua error from luaT_tuple_new() Alexander Turenko 2020-10-14 23:41 ` Vladislav Shpilevoy 2020-10-15 13:17 ` Alexander Turenko 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 06/16] module api/lua: add luaT_tuple_encode() Alexander Turenko 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 07/16] module api/lua: expose luaT_tuple_new() Alexander Turenko 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 08/16] module api/lua: add API_EXPORT to tuple functions Alexander Turenko 2020-10-14 23:41 ` Vladislav Shpilevoy 2020-10-15 2:35 ` Alexander Turenko 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 09/16] module api: add API_EXPORT to key_def functions Alexander Turenko 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 10/16] module api: add box_key_def_new_v2() Alexander Turenko 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 11/16] module api: add box_key_def_dump_parts() Alexander Turenko 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 12/16] module api: expose box_key_def_validate_tuple() Alexander Turenko 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 13/16] module api: expose box_key_def_merge() Alexander Turenko 2020-10-14 23:41 ` Vladislav Shpilevoy 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 14/16] module api: expose box_key_def_extract_key() Alexander Turenko 2020-10-14 23:41 ` Vladislav Shpilevoy 2020-10-15 2:39 ` Alexander Turenko 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 15/16] module api: add box_key_def_validate_key() Alexander Turenko 2020-10-14 23:41 ` Vladislav Shpilevoy 2020-10-15 13:18 ` Alexander Turenko 2020-10-12 23:23 ` [Tarantool-patches] [PATCH v3 16/16] module api: add box_key_def_validate_full_key() Alexander Turenko 2020-10-14 23:41 ` [Tarantool-patches] [PATCH v3 00/16] module api: extend for external key_def Lua module Vladislav Shpilevoy 2020-10-15 3:09 ` Alexander Turenko 2020-10-15 13:19 ` Alexander Turenko 2020-10-16 6:05 ` Alexander Turenko 2020-10-15 20:12 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201015131716.4wmw66boyslayssy@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v3 02/16] module api: expose box region' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox