From: Igor Munkin <imun@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 5/5] gitlab-ci: add out-of-source build
Date: Thu, 15 Oct 2020 15:30:10 +0300 [thread overview]
Message-ID: <20201015123010.GD32659@tarantool.org> (raw)
In-Reply-To: <dcdcc168c316aa4d74a0566c8d520dcaa23eeaa0.1602663758.git.avtikhon@tarantool.org>
Sasha,
Thanks for the patch! LGTM, except a couple of nits below.
On 14.10.20, Alexander V. Tikhonov wrote:
> Implemented out-of-source build at cmake files. Added out of source
Typo: The first sentence doesn't relate to the patch.
> build make targets and added test job to gitlab-ci.
>
> Closes #4874
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4874-out-of-source-build-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4874
>
> V2: removed changes not for gitlab-ci.
>
> .gitlab-ci.yml | 7 +++++++
> .travis.mk | 26 +++++++++++++++++++++++++-
> 2 files changed, 32 insertions(+), 1 deletion(-)
>
<snipped>
> diff --git a/.travis.mk b/.travis.mk
> index d797472e2..5730e1097 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -7,7 +7,9 @@ DOCKER_IMAGE_TARANTOOL="registry.gitlab.com/tarantool/tarantool/testing/debian-s
> TEST_RUN_EXTRA_PARAMS?=
> MAX_FILES?=65534
> MAX_PROC?=2500
> -OOS_SRC_PATH="/source"
> +OOS_SRC_PATH?="/source"
> +OOS_BUILD_PATH?="/rw_bins"
Minor: All these quotes are excess[1], but break nothing.
> +OOS_BUILD_RULE?=test_oos_no_deps
> BIN_DIR=/usr/local/bin
> OSX_VARDIR?=/tmp/tnt
>
<snipped>
> --
> 2.25.1
>
[1]: https://gitlab.com/tarantool/tarantool/-/jobs/790306507#L3757
--
Best regards,
IM
next prev parent reply other threads:[~2020-10-15 12:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 8:27 [Tarantool-patches] [PATCH v1 1/5] curl: enable curl build with old cmake Alexander V. Tikhonov
2020-10-14 8:29 ` [Tarantool-patches] [PATCH v1 2/5] build: set include path to bootstrap.h Alexander V. Tikhonov
2020-10-15 9:18 ` Igor Munkin
2021-03-12 8:55 ` Kirill Yukhin via Tarantool-patches
2020-10-14 8:30 ` [Tarantool-patches] [PATCH v1 3/5] build: correct destination build directory Alexander V. Tikhonov
2020-10-15 12:24 ` Igor Munkin
2020-10-14 8:35 ` [Tarantool-patches] [PATCH v1 5/5] gitlab-ci: add out-of-source build Alexander V. Tikhonov
2020-10-15 12:30 ` Igor Munkin [this message]
2020-10-14 9:25 ` [Tarantool-patches] [PATCH v4 4/5] build: enable cmake in curl build Alexander V. Tikhonov
2020-10-15 14:17 ` Igor Munkin
2020-10-15 19:00 ` Alexander V. Tikhonov
2020-10-15 20:43 ` Igor Munkin
2020-10-15 12:23 ` [Tarantool-patches] [PATCH v1 1/5] curl: enable curl build with old cmake Igor Munkin
2020-10-16 6:55 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015123010.GD32659@tarantool.org \
--to=imun@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 5/5] gitlab-ci: add out-of-source build' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox