From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id EBEFA469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 15 Oct 2020 15:40:48 +0300 (MSK)
Date: Thu, 15 Oct 2020 15:30:10 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201015123010.GD32659@tarantool.org>
References: <0a48783b74bcb4fbdb3ff6f3decc79bded564bec.1602663758.git.avtikhon@tarantool.org>
 <dcdcc168c316aa4d74a0566c8d520dcaa23eeaa0.1602663758.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <dcdcc168c316aa4d74a0566c8d520dcaa23eeaa0.1602663758.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 5/5] gitlab-ci: add out-of-source
	build
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sasha,

Thanks for the patch! LGTM, except a couple of nits below.

On 14.10.20, Alexander V. Tikhonov wrote:
> Implemented out-of-source build at cmake files. Added out of source

Typo: The first sentence doesn't relate to the patch.

> build make targets and added test job to gitlab-ci.
> 
> Closes #4874
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4874-out-of-source-build-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4874
> 
> V2: removed changes not for gitlab-ci.
> 
>  .gitlab-ci.yml |  7 +++++++
>  .travis.mk     | 26 +++++++++++++++++++++++++-
>  2 files changed, 32 insertions(+), 1 deletion(-)
> 

<snipped>

> diff --git a/.travis.mk b/.travis.mk
> index d797472e2..5730e1097 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -7,7 +7,9 @@ DOCKER_IMAGE_TARANTOOL="registry.gitlab.com/tarantool/tarantool/testing/debian-s
>  TEST_RUN_EXTRA_PARAMS?=
>  MAX_FILES?=65534
>  MAX_PROC?=2500
> -OOS_SRC_PATH="/source"
> +OOS_SRC_PATH?="/source"
> +OOS_BUILD_PATH?="/rw_bins"

Minor: All these quotes are excess[1], but break nothing.

> +OOS_BUILD_RULE?=test_oos_no_deps
>  BIN_DIR=/usr/local/bin
>  OSX_VARDIR?=/tmp/tnt
>  

<snipped>

> -- 
> 2.25.1
> 

[1]: https://gitlab.com/tarantool/tarantool/-/jobs/790306507#L3757

-- 
Best regards,
IM