Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin <imun@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 3/5] build: correct destination build directory
Date: Thu, 15 Oct 2020 15:24:04 +0300	[thread overview]
Message-ID: <20201015122404.GC32659@tarantool.org> (raw)
In-Reply-To: <d4965ab855be77ac67ff7c9e343c84622e6f176f.1602663758.git.avtikhon@tarantool.org>

Sasha,

Thanks for the patch! Consider the related comments here[1].
Otherwise, the changes LGTM.

[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-October/020236.html

-- 
Best regards,
IM

  reply	other threads:[~2020-10-15 12:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14  8:27 [Tarantool-patches] [PATCH v1 1/5] curl: enable curl build with old cmake Alexander V. Tikhonov
2020-10-14  8:29 ` [Tarantool-patches] [PATCH v1 2/5] build: set include path to bootstrap.h Alexander V. Tikhonov
2020-10-15  9:18   ` Igor Munkin
2021-03-12  8:55   ` Kirill Yukhin via Tarantool-patches
2020-10-14  8:30 ` [Tarantool-patches] [PATCH v1 3/5] build: correct destination build directory Alexander V. Tikhonov
2020-10-15 12:24   ` Igor Munkin [this message]
2020-10-14  8:35 ` [Tarantool-patches] [PATCH v1 5/5] gitlab-ci: add out-of-source build Alexander V. Tikhonov
2020-10-15 12:30   ` [Tarantool-patches] [PATCH v2 " Igor Munkin
2020-10-14  9:25 ` [Tarantool-patches] [PATCH v4 4/5] build: enable cmake in curl build Alexander V. Tikhonov
2020-10-15 14:17   ` Igor Munkin
2020-10-15 19:00     ` Alexander V. Tikhonov
2020-10-15 20:43       ` Igor Munkin
2020-10-15 12:23 ` [Tarantool-patches] [PATCH v1 1/5] curl: enable curl build with old cmake Igor Munkin
2020-10-16  6:55 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201015122404.GC32659@tarantool.org \
    --to=imun@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 3/5] build: correct destination build directory' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox