From: Kirill Yukhin <kyukhin@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/4] build: fix Werror warning in src/box/txn.c
Date: Thu, 15 Oct 2020 11:53:03 +0300 [thread overview]
Message-ID: <20201015085303.ghty6d62wj723plt@tarantool.org> (raw)
In-Reply-To: <db71f95c3f2d20dbebc8ef7a0013e403751f8b53.1602693164.git.avtikhon@tarantool.org>
Hello,
On 14 окт 19:35, Alexander V. Tikhonov wrote:
> Found on GCC 4.8.5 on CentOS 7 issue:
>
> build/usr/src/debug/tarantool-2.6.0.144/src/box/txn.c:944:30: error: ‘limbo_entry’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> if (txn_limbo_wait_complete(&txn_limbo, limbo_entry) < 0)
>
> Set limbo_entry variable to NULL on initialization.
>
> Needed for #4941
I've checked your patch into 2.5 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-10-15 8:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 16:35 Alexander V. Tikhonov
2020-10-14 16:35 ` [Tarantool-patches] [PATCH v1 2/4] build: fix Werror warning in test/unit:fiber*.c* Alexander V. Tikhonov
2020-10-14 16:35 ` [Tarantool-patches] [PATCH v1 3/4] build: add Werror flag to CentOS7 packages build Alexander V. Tikhonov
2020-10-14 16:35 ` [Tarantool-patches] [PATCH v1 4/4] gitlab-ci: test default gcc on CentOS 7 Alexander V. Tikhonov
2020-10-15 8:53 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015085303.ghty6d62wj723plt@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 1/4] build: fix Werror warning in src/box/txn.c' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox