From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CFE54469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 15 Oct 2020 11:53:04 +0300 (MSK)
Date: Thu, 15 Oct 2020 11:53:03 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20201015085303.ghty6d62wj723plt@tarantool.org>
References: <db71f95c3f2d20dbebc8ef7a0013e403751f8b53.1602693164.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <db71f95c3f2d20dbebc8ef7a0013e403751f8b53.1602693164.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1 1/4] build: fix Werror warning in
	src/box/txn.c
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 14 окт 19:35, Alexander V. Tikhonov wrote:
> Found on GCC 4.8.5 on CentOS 7 issue:
> 
>   build/usr/src/debug/tarantool-2.6.0.144/src/box/txn.c:944:30: error: ‘limbo_entry’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>      if (txn_limbo_wait_complete(&txn_limbo, limbo_entry) < 0)
> 
> Set limbo_entry variable to NULL on initialization.
> 
> Needed for #4941

I've checked your patch into 2.5 and master.

--
Regards, Kirill Yukhin