Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Artem Starshov <artemreyt@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] luacheck: fixed warning in tarantoolctl.in
Date: Thu, 15 Oct 2020 02:04:37 +0300	[thread overview]
Message-ID: <20201014230437.zflzpujzknxompvs@tkn_work_nb> (raw)
In-Reply-To: <2a19304adfd3877d0fa26cde1d8d8c313a291588.1602677553.git.artemreyt@tarantool.org>

LGTM.

Pushed to master and 2.5.

WBR, Alexander Turenko.

On Wed, Oct 14, 2020 at 03:14:08PM +0300, Artem Starshov wrote:
> luacheck: fixed warning in tarantoolctl.in

Nit: Use imperative mood in a commit header, 'fix' instead of 'fixed'.

> Changed passing global variable arg to function
> find_instance_name(arg) instead of passing arg[0] and arg[2] separately.
> And removed exception in .luacheckrc for file /extra/dist/tarantoolctl.in.

Nit: Fit the commit message body to 72 symbols (at least for a prose
text, but not necessary for listings and so).

> 
> This change only solves linter warning, nothing else.
> 
> Fixed #4929.

The commit message on the branch is the previous one. Next time, please,
keep a branch in sync with patches you send to the mailing list.

      parent reply	other threads:[~2020-10-14 23:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 12:14 Artem Starshov
2020-10-14 13:11 ` Leonid Vasiliev
2020-10-14 23:04 ` Alexander Turenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201014230437.zflzpujzknxompvs@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=artemreyt@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] luacheck: fixed warning in tarantoolctl.in' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox