From: Igor Munkin <imun@tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 0/2] Fix broken CI after introduced LuaJIT metrics Date: Wed, 14 Oct 2020 22:47:59 +0300 [thread overview] Message-ID: <20201014194759.GK18920@tarantool.org> (raw) In-Reply-To: <cover.1602694006.git.skaplun@tarantool.org> I believe it's a good practice to add the link with green CI for the branch too. This is definitely not obligatory, but I guess it can help to reduce the issues we fixed in scope of this patchset. On 14.10.20, Sergey Kaplun wrote: > This patch fixes the regressions introduced in scope of > 5a61e1ab54b5c66bfebd836db1ac47996611e065 ('misc: add C and Lua API for > platform metrics'). > > Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5187-fix-tests-fails-ci > This branch is rebased on Igor's branch: > https://github.com/tarantool/luajit/tree/imun/gh-5187-fix-disp-encoding-on-gc64 > > CI: https://gitlab.com/tarantool/tarantool/-/pipelines/202569424/builds You've already it here, great! > Side note: failing CI at osx jobs related to this issue: > https://github.com/tarantool/tarantool/issues/5423 > > Sergey Kaplun (2): > test: force enable assert checks in release build > test: disable jit related tests at FreeBSD > > test/misclib-getmetrics-capi.skipcond | 7 +++++++ > test/misclib-getmetrics-capi/testgetmetrics.c | 1 + > test/misclib-getmetrics-lapi.skipcond | 7 +++++++ > 3 files changed, 15 insertions(+) > create mode 100644 test/misclib-getmetrics-capi.skipcond > create mode 100644 test/misclib-getmetrics-lapi.skipcond > > -- > 2.28.0 > -- Best regards, IM
next prev parent reply other threads:[~2020-10-14 19:58 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-14 17:03 Sergey Kaplun 2020-10-14 17:03 ` [Tarantool-patches] [PATCH 1/2] test: force enable assert checks in release build Sergey Kaplun 2020-10-14 19:29 ` Igor Munkin 2020-10-14 19:33 ` Igor Munkin 2020-10-15 7:23 ` Sergey Kaplun 2020-10-15 9:02 ` Sergey Ostanevich 2020-10-14 17:03 ` [Tarantool-patches] [PATCH 2/2] test: disable jit related tests at FreeBSD Sergey Kaplun 2020-10-14 19:43 ` Igor Munkin 2020-10-15 7:25 ` Sergey Kaplun 2020-10-15 9:04 ` Sergey Ostanevich 2020-10-14 19:47 ` Igor Munkin [this message] 2020-10-15 9:22 ` [Tarantool-patches] [PATCH 0/2] Fix broken CI after introduced LuaJIT metrics Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201014194759.GK18920@tarantool.org \ --to=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 0/2] Fix broken CI after introduced LuaJIT metrics' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox