From: Igor Munkin <imun@tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] test: disable jit related tests at FreeBSD
Date: Wed, 14 Oct 2020 22:43:10 +0300 [thread overview]
Message-ID: <20201014194310.GJ18920@tarantool.org> (raw)
In-Reply-To: <098b637d1a67b7a0e8215d8d4cd9327b6a0e266c.1602694006.git.skaplun@tarantool.org>
Sergey,
Thanks for the patch! It LGTM, but I can't stop nitpicking :)
On 14.10.20, Sergey Kaplun wrote:
> This patch fixes the regression introduced in scope of
> 5a61e1ab54b5c66bfebd836db1ac47996611e065 ('misc: add C and Lua API for
> platform metrics').
>
> As far as newly added tests include trace checks and
> https://github.com/tarantool/tarantool/issues/4819 (JIT fails to
Minor: Let's be consistent in referring external issues:
| tarantool/tarantool#4819
> allocate mcode memory on FreeBSD) has not resolved yet, this tests
Typo: s/this/these/.
> should be disabled to for running on FreeBSD.
Typo: s/to for/while/.
>
> Follows up tarantool/tarantool#5187
> ---
<snipped>
> --
> 2.28.0
>
--
Best regards,
IM
next prev parent reply other threads:[~2020-10-14 19:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 17:03 [Tarantool-patches] [PATCH 0/2] Fix broken CI after introduced LuaJIT metrics Sergey Kaplun
2020-10-14 17:03 ` [Tarantool-patches] [PATCH 1/2] test: force enable assert checks in release build Sergey Kaplun
2020-10-14 19:29 ` Igor Munkin
2020-10-14 19:33 ` Igor Munkin
2020-10-15 7:23 ` Sergey Kaplun
2020-10-15 9:02 ` Sergey Ostanevich
2020-10-14 17:03 ` [Tarantool-patches] [PATCH 2/2] test: disable jit related tests at FreeBSD Sergey Kaplun
2020-10-14 19:43 ` Igor Munkin [this message]
2020-10-15 7:25 ` Sergey Kaplun
2020-10-15 9:04 ` Sergey Ostanevich
2020-10-14 19:47 ` [Tarantool-patches] [PATCH 0/2] Fix broken CI after introduced LuaJIT metrics Igor Munkin
2020-10-15 9:22 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014194310.GJ18920@tarantool.org \
--to=imun@tarantool.org \
--cc=skaplun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] test: disable jit related tests at FreeBSD' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox