From: Cyrill Gorcunov <gorcunov@gmail.com> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, Serge Petrenko <sergepetrenko@tarantool.org> Cc: tml <tarantool-patches@dev.tarantool.org> Subject: [Tarantool-patches] [PATCH 0/2] raft: a few fixes Date: Wed, 14 Oct 2020 17:26:15 +0300 [thread overview] Message-ID: <20201014142617.235813-1-gorcunov@gmail.com> (raw) Vlad, Sergey, here are a few nitpicks. Feel free to ignore just came to mind while been reading the code. The issue with potential nil dereference for raft worker should be addressed separately on top of the Vlad fixes. Cyrill Gorcunov (2): raft: raft_request_to_string -- don't hardcode size raft: decode even invalid states of raft src/box/lua/info.c | 2 +- src/box/raft.c | 31 ++++++++++++++++++++++--------- src/box/raft.h | 11 ++++++++++- 3 files changed, 33 insertions(+), 11 deletions(-) -- 2.26.2
next reply other threads:[~2020-10-14 14:26 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-14 14:26 Cyrill Gorcunov [this message] 2020-10-14 14:26 ` [Tarantool-patches] [PATCH 1/2] raft: raft_request_to_string -- don't hardcode size Cyrill Gorcunov 2020-10-14 14:26 ` [Tarantool-patches] [PATCH 2/2] raft: decode even invalid states of raft Cyrill Gorcunov 2020-10-15 9:43 ` Serge Petrenko 2020-10-15 9:46 ` Cyrill Gorcunov 2020-10-27 22:18 ` Vladislav Shpilevoy 2020-10-27 22:36 ` Cyrill Gorcunov 2020-10-15 8:44 ` [Tarantool-patches] [PATCH 0/2] raft: a few fixes Cyrill Gorcunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201014142617.235813-1-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=sergepetrenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 0/2] raft: a few fixes' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox