From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] build: another fix for luajit-tap tests cmake
Date: Tue, 13 Oct 2020 17:45:24 +0300 [thread overview]
Message-ID: <20201013144524.GA921357@hpalx> (raw)
In-Reply-To: <a99f70ebea28d07ba73aaf4604b1f55774ad06f3.1602598947.git.imun@tarantool.org>
Hi Igor, thanks for the fast fix. I've checked it and saw that it really
fixed the issue. Patch LGTM.
On Tue, Oct 13, 2020 at 05:27:24PM +0300, Igor Munkin wrote:
> Fixes the regression from e5039742eba89936bf2f8c5aebc8f21c810710d5
> ('luajit: bump new version').
>
> Reported-by: Alexander Tikhonov <avtikhon@tarantool.org>
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
>
> Branch: https://github.com/tarantool/tarantool/tree/imun/luajit-tests-fixup-again
>
> test/CMakeLists.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
> index c8759703c..7b28e2bd4 100644
> --- a/test/CMakeLists.txt
> +++ b/test/CMakeLists.txt
> @@ -77,6 +77,7 @@ add_subdirectory(box-tap)
> add_subdirectory(unit)
> add_subdirectory(${PROJECT_SOURCE_DIR}/third_party/luajit/test/gh-4427-ffi-sandwich ${PROJECT_BINARY_DIR}/third_party/luajit/test/gh-4427-ffi-sandwich)
> add_subdirectory(${PROJECT_SOURCE_DIR}/third_party/luajit/test/lj-flush-on-trace ${PROJECT_BINARY_DIR}/third_party/luajit/test/lj-flush-on-trace)
> +add_subdirectory(${PROJECT_SOURCE_DIR}/third_party/luajit/test/misclib-getmetrics-capi ${PROJECT_BINARY_DIR}/third_party/luajit/test/misclib-getmetrics-capi)
>
> # Move tarantoolctl config
> if (NOT ${PROJECT_BINARY_DIR} STREQUAL ${PROJECT_SOURCE_DIR})
> --
> 2.25.0
>
next prev parent reply other threads:[~2020-10-13 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 14:27 Igor Munkin
2020-10-13 14:45 ` Alexander V. Tikhonov [this message]
2020-10-13 14:49 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013144524.GA921357@hpalx \
--to=avtikhon@tarantool.org \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] build: another fix for luajit-tap tests cmake' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox