From: Kirill Yukhin <kyukhin@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, alexander.turenko@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v4] key_def: support composite types extraction
Date: Tue, 13 Oct 2020 16:22:26 +0300 [thread overview]
Message-ID: <20201013132226.tifrxxxhbo5nc3ar@tarantool.org> (raw)
In-Reply-To: <20201013120239.29831-1-i.kosarev@tarantool.org>
Hello,
On 13 окт 15:02, Ilya Kosarev wrote:
> key_def didn't support key definitions with array, map, varbinary & any
> fields. Thus they couldn't be extracted with
> key_def_object:extract_key(). Since the restriction existed due to
> impossibility of such types comparison, this patch removes the
> restriction for the fields extraction and only leaves it for
> comparison.
>
> Closes #4538
> ---
> Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4538-key_def-extract-arrays
> Issue: https://github.com/tarantool/tarantool/issues/4538
I've checked your patch into master and added an entry to relase notes.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-10-13 13:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 12:02 Ilya Kosarev
2020-10-13 13:22 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013132226.tifrxxxhbo5nc3ar@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4] key_def: support composite types extraction' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox