From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Timur Safin <tsafin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2.X v3 2/3] module api: export box_key_def_dup
Date: Tue, 13 Oct 2020 03:46:32 +0300 [thread overview]
Message-ID: <20201013004632.lh5sfqxcqxilerct@tkn_work_nb> (raw)
In-Reply-To: <faf56d41670aef2eea658c5abe21672902983be0.1602463103.git.tsafin@tarantool.org>
Everything is okay, but I would add a test case. You can use the
box_key_def_dump_parts() function + the key_part_def_check_equal()
helper to verify equality of two key_defs or create your own wrapper for
two key_defs similar to key_def_check_merge() (see the recent branch re
key_def APIs, I have updated it today).
On Mon, Oct 12, 2020 at 03:44:10AM +0300, Timur Safin wrote:
> Exporting `box_key_def_dup` as accessor to the internal `key_def_dup`
>
> Part of #5384
next prev parent reply other threads:[~2020-10-13 0:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 0:44 [Tarantool-patches] [PATCH 2.X v3 0/3] module api: extend for external merger Lua module Timur Safin
2020-10-12 0:44 ` [Tarantool-patches] [PATCH 2.X v3 1/3] module api: export box_tuple_validate Timur Safin
2020-10-13 0:14 ` Alexander Turenko
2020-10-13 0:35 ` Timur Safin
2020-10-12 0:44 ` [Tarantool-patches] [PATCH 2.X v3 2/3] module api: export box_key_def_dup Timur Safin
2020-10-13 0:46 ` Alexander Turenko [this message]
2020-10-12 0:44 ` [Tarantool-patches] [PATCH 2.X v3 3/3] module api: luaL_checkibuf Timur Safin
2020-10-13 11:47 ` Alexander Turenko
2020-10-13 19:26 ` Igor Munkin
2020-10-13 16:30 ` [Tarantool-patches] [PATCH 2.X v3] module api: box_ibuf_* wrappers Timur Safin
2020-10-13 18:21 ` Alexander Turenko
2020-10-13 19:02 ` Timur Safin
2020-10-13 19:58 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013004632.lh5sfqxcqxilerct@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tsafin@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2.X v3 2/3] module api: export box_key_def_dup' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox