Tarantool development patches archive
 help / color / mirror / Atom feed
From: Serge Petrenko <sergepetrenko@tarantool.org>
To: avtikhon@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH] test: merge possilbe failed test outputs for election_qsync
Date: Mon, 12 Oct 2020 15:09:04 +0300	[thread overview]
Message-ID: <20201012120904.93757-1-sergepetrenko@tarantool.org> (raw)

Instead of having all possible 2^10 diffs in case select{} fails,
log the select{} output in case the space contains less than 10
elements.
Requested by @avtikhon for easier flaky test handling.

Related to #5395
---
https://github.com/tarantool/tarantool/issues/5395
https://github.com/tarantool/tarantool/tree/sp/gh-5395-minimize-test-output

 test/replication/election_qsync.result   | 15 +++------------
 test/replication/election_qsync.test.lua |  2 +-
 2 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/test/replication/election_qsync.result b/test/replication/election_qsync.result
index 9497b37bf..09a76c51c 100644
--- a/test/replication/election_qsync.result
+++ b/test/replication/election_qsync.result
@@ -109,18 +109,9 @@ test_run:cmd('setopt delimiter ""');
  | - true
  | ...
 -- We're connected to some leader.
-c.space.test:select{}
- | ---
- | - - [1]
- |   - [2]
- |   - [3]
- |   - [4]
- |   - [5]
- |   - [6]
- |   - [7]
- |   - [8]
- |   - [9]
- |   - [10]
+#c.space.test:select{} == 10 or require('log').error(c.space.test:select{})
+ | ---
+ | - true
  | ...
 
 test_run:drop_cluster(SERVERS)
diff --git a/test/replication/election_qsync.test.lua b/test/replication/election_qsync.test.lua
index bca1b20c7..f84ca8440 100644
--- a/test/replication/election_qsync.test.lua
+++ b/test/replication/election_qsync.test.lua
@@ -68,6 +68,6 @@ for i = 1,10 do
 end;
 test_run:cmd('setopt delimiter ""');
 -- We're connected to some leader.
-c.space.test:select{}
+#c.space.test:select{} == 10 or require('log').error(c.space.test:select{})
 
 test_run:drop_cluster(SERVERS)
-- 
2.24.3 (Apple Git-128)

             reply	other threads:[~2020-10-12 12:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12 12:09 Serge Petrenko [this message]
2020-10-13 13:09 ` Alexander V. Tikhonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201012120904.93757-1-sergepetrenko@tarantool.org \
    --to=sergepetrenko@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] test: merge possilbe failed test outputs for election_qsync' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox