From: Nikita Pettik <korablev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 0/2] vinyl: rework upsert operation
Date: Fri, 9 Oct 2020 15:10:21 +0000 [thread overview]
Message-ID: <20201009151021.GB31117@tarantool.org> (raw)
In-Reply-To: <6643130f-6b57-7c15-fb79-4bdd4873f561@tarantool.org>
On 07 Oct 00:12, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patchset!
>
> Does this patchset change format of vinyl statements on disk? If yes, I guess
> it breaks backward compatibility. Did you check how does it behave when booted
> from files of a previous version? Does it crash? Does it report an error? How
> a user can upgrade his vinyl files to the new format?
No, everything goes fine except the fact that upsert statements restored
from disk have ops encoded into single array and as a result being applied
may break associative property (like it was before this patch). I've tried
to add a test, but since squash operation modifies content of run/xlog files,
such test can be run only once. If it is vital, I guess it is possible to
copy data directory before each test run..
next prev parent reply other threads:[~2020-10-09 15:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 13:28 Nikita Pettik
2020-10-03 13:28 ` [Tarantool-patches] [PATCH v3 1/2] " Nikita Pettik
2020-10-06 22:12 ` Vladislav Shpilevoy
2020-10-09 15:06 ` Nikita Pettik
2020-10-13 19:00 ` Aleksandr Lyapunov
2020-10-14 0:15 ` Nikita Pettik
2020-10-14 8:58 ` Aleksandr Lyapunov
2020-10-14 10:42 ` Nikita Pettik
2020-10-14 11:47 ` Aleksandr Lyapunov
2020-10-15 0:36 ` Nikita Pettik
2020-10-03 13:28 ` [Tarantool-patches] [PATCH v3 2/2] vinyl: remove squash procedures from source code Nikita Pettik
2020-10-03 13:52 ` [Tarantool-patches] [PATCH v3 0/2] vinyl: rework upsert operation Nikita Pettik
2020-10-06 22:12 ` Vladislav Shpilevoy
2020-10-09 15:10 ` Nikita Pettik [this message]
2020-10-11 15:35 ` Vladislav Shpilevoy
2020-10-11 15:35 ` Vladislav Shpilevoy
2020-10-13 10:18 ` Nikita Pettik
2020-10-14 23:44 ` Vladislav Shpilevoy
2020-10-15 1:42 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009151021.GB31117@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 0/2] vinyl: rework upsert operation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox