From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 37A17469719 for ; Fri, 9 Oct 2020 18:10:22 +0300 (MSK) Date: Fri, 9 Oct 2020 15:10:21 +0000 From: Nikita Pettik Message-ID: <20201009151021.GB31117@tarantool.org> References: <6643130f-6b57-7c15-fb79-4bdd4873f561@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6643130f-6b57-7c15-fb79-4bdd4873f561@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v3 0/2] vinyl: rework upsert operation List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org On 07 Oct 00:12, Vladislav Shpilevoy wrote: > Hi! Thanks for the patchset! > > Does this patchset change format of vinyl statements on disk? If yes, I guess > it breaks backward compatibility. Did you check how does it behave when booted > from files of a previous version? Does it crash? Does it report an error? How > a user can upgrade his vinyl files to the new format? No, everything goes fine except the fact that upsert statements restored from disk have ops encoded into single array and as a result being applied may break associative property (like it was before this patch). I've tried to add a test, but since squash operation modifies content of run/xlog files, such test can be run only once. If it is vital, I guess it is possible to copy data directory before each test run..